Skip to content

IGNITE-28603 Fix ToStringDumpHelperTest on JDK 17 #13074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wernerdv wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −15
Open

IGNITE-28603 Fix ToStringDumpHelperTest on JDK 17 #13074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions ...s/cache/persistence/diagnostic/pagelocktracker/dumpprocessors/ToStringDumpHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,17 @@

package org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.dumpprocessors;

import java.time.Instant;
import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockDump;
import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.SharedPageLockTracker;
import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.SharedPageLockTrackerDump;
import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.ThreadPageLockState;
import org.apache.ignite.internal.processors.cache.persistence.tree.util.PageLockListener;
import org.apache.ignite.internal.util.typedef.internal.U;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.junit.Test;

/**
* Unit tests for {@link ToStringDumpHelper}.
*/
public class ToStringDumpHelperTest extends GridCommonAbstractTest {
/** */
private static final long TIME = 1596173397167L;

/** */
@Test
public void toStringSharedPageLockTrackerTest() throws Exception {
Expand All @@ -54,26 +47,28 @@ public void toStringSharedPageLockTrackerTest() throws Exception {

SharedPageLockTrackerDump pageLockDump = pageLockTracker.dump();

// Hack to have same timestamp in test.
for (ThreadPageLockState state : pageLockDump.threadPageLockStates)
GridTestUtils.setFieldValue(state.pageLockDump, PageLockDump.class, "time", TIME);

assertNotNull(pageLockDump);

String dumpStr = ToStringDumpHelper.toStringDump(pageLockDump);

String expectedLog = "Page locks dump:" + U.nl() +
String expectedLogPrefix = "Page locks dump:" + U.nl() +
U.nl() +
"Thread=[name=async-lock-unlock, id=" + threadIdInLog + "], state=TERMINATED" + U.nl() +
"Locked pages = [32[0000000000000020](r=1|w=0)]" + U.nl() +
"Locked pages log: name=async-lock-unlock time=(1596173397167, " +
ToStringDumpHelper.DATE_FMT.format(Instant.ofEpochMilli(TIME)) + ")" + U.nl() +
"Locked pages log: name=async-lock-unlock time=(";

String expectedLogSuffix = ")" + U.nl() +
"L=1 -> Read lock pageId=32, structureId=dummy [pageIdHex=0000000000000020, partId=0, pageIdx=32, flags=00000000]" +
U.nl() +
U.nl() +
U.nl() +
U.nl();

assertEquals(expectedLog, dumpStr);
assertTrue(dumpStr.startsWith(expectedLogPrefix));
assertTrue(dumpStr.endsWith(expectedLogSuffix));

String timestamp = dumpStr.substring(expectedLogPrefix.length(), dumpStr.indexOf(')', expectedLogPrefix.length()));

assertTrue(timestamp.matches("\\d+, \\d{4}-\\d{2}-\\d{2} \\d{2}:\\d{2}:\\d{2}\\.\\d{3}"));
}
}