Skip to content

test: add regression tests for FileConfiguration #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amirdeljouyi wants to merge 1 commit into
base: 2.x
Choose a base branch
from
+44 −0
Open

test: add regression tests for FileConfiguration #8151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions config/seata-config-core/src/test/java/org/apache/seata/config/FileConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,4 +471,48 @@ void testGetConfigFromEnvironmentVariable() {
String path = fileConfig.getConfigFromSys("PATH");
Assertions.assertNotNull(path);
}

@Test
void shouldDelegateFileBackedReadsThroughConfigurationFactory() {
String dataId = "service.disableGlobalTransaction";
String previousValue = System.getProperty(dataId);
try {
System.clearProperty(dataId);
ConfigurationFactory.reload();
Configuration fileConfig = ConfigurationFactory.getInstance();

Assertions.assertEquals("127.0.0.1:8091", fileConfig.getConfig("service.default.grouplist"));
Assertions.assertFalse(fileConfig.getBoolean(dataId));
} finally {
if (previousValue == null) {
System.clearProperty(dataId);
} else {
System.setProperty(dataId, previousValue);
}
ConfigurationFactory.reload();
}
Comment on lines +477 to +493
}

@Test
void shouldReturnDefaultsForMissingConfigurationThroughConfigurationFactory() {
Configuration fileConfig = ConfigurationFactory.getInstance();

Assertions.assertNull(fileConfig.getConfig("adopted.missing.key"));
Assertions.assertEquals("fallback", fileConfig.getLatestConfig("adopted.missing.key", "fallback", 1000L));
Assertions.assertEquals(39, fileConfig.getInt("adopted.missing.int", 39));
Assertions.assertEquals((short) 2, fileConfig.getShort("adopted.missing.short", (short) 2));
}

@Test
void shouldReportMutationOperationOutcomeThroughConfigurationFactory() {
Configuration fileConfig = ConfigurationFactory.getInstance();

Assertions.assertTrue(fileConfig.putConfig("adopted.put.key", "value", 1000L));
Assertions.assertTrue(fileConfig.putConfigIfAbsent("adopted.put-if-absent.key", "value", 1000L));
Assertions.assertTrue(fileConfig.removeConfig("adopted.remove.key", 1000L));
Comment on lines +510 to +512

Assertions.assertFalse(fileConfig.putConfig("adopted.expired.put.key", "value", -1L));
Assertions.assertFalse(fileConfig.putConfigIfAbsent("adopted.expired.put-if-absent.key", "value", -1L));
Assertions.assertFalse(fileConfig.removeConfig("adopted.expired.remove.key", -1L));
}
}
Loading