Skip to content

Commit 553d727

Browse files
committed
fix reviewed issues
1 parent 485fd2d commit 553d727

4 files changed

Lines changed: 21 additions & 8 deletions

File tree

integration-test/src/test/java/org/apache/iotdb/db/it/orderBy/IoTDBOrderByIT.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,10 @@ public class IoTDBOrderByIT {
100100
@BeforeClass
101101
public static void setUp() throws Exception {
102102
EnvFactory.getEnv().getConfig().getDataNodeCommonConfig().setSortBufferSize(1024 * 1024L);
103+
EnvFactory.getEnv()
104+
.getConfig()
105+
.getDataNodeCommonConfig()
106+
.setQueryMemoryProportion("1:100:200:50:200:400:200:50");
103107
EnvFactory.getEnv().initClusterEnvironment();
104108
insertData();
105109
}

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/schema/SchemaFetchScanOperator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public TsBlock next() throws Exception {
163163
boolean isFirstBatch = schemaNodeIteratorForSerialize == null;
164164
prepareSchemaNodeIteratorForSerialize();
165165
// to indicate this binary data is database info
166-
ReadWriteIOUtils.write((byte) 1, baos);
166+
ReadWriteIOUtils.write((byte) 2, baos);
167167
// the estimated mem cost to deserialize the total schema tree
168168
if (isFirstBatch) {
169169
ReadWriteIOUtils.write(schemaTreeMemCost, baos);
@@ -178,7 +178,7 @@ public TsBlock next() throws Exception {
178178
isFinished = !schemaNodeIteratorForSerialize.hasNext();
179179
if (isFinished) {
180180
// indicate all continuous binary data is finished
181-
currentBatch[0] = 2;
181+
currentBatch[0] = 3;
182182
releaseSchemaTree();
183183
baos = null;
184184
}

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/schema/ClusterSchemaFetchExecutor.java

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -303,14 +303,23 @@ private void parseFetchedData(
303303
for (int i = 0; i < size; i++) {
304304
databaseSet.add(ReadWriteIOUtils.readString(inputStream));
305305
}
306-
} else if (type == 1 || type == 2) {
306+
} else if (type == 1) {
307+
// for data from old version
308+
ClusterSchemaTree deserializedSchemaTree = ClusterSchemaTree.deserialize(inputStream);
309+
if (context != null) {
310+
context.reserveMemoryForSchemaTree(deserializedSchemaTree.ramBytesUsed());
311+
}
312+
resultSchemaTree.mergeSchemaTree(deserializedSchemaTree);
313+
} else if (type == 2 || type == 3) {
307314
if (deserializer.isFirstBatch()) {
308315
long memCost = ReadWriteIOUtils.readLong(inputStream);
309-
context.reserveMemoryForSchemaTree(memCost);
316+
if (context != null) {
317+
context.reserveMemoryForSchemaTree(memCost);
318+
}
310319
}
311320
deserializer.deserializeFromBatch(inputStream);
312-
if (type == 2) {
313-
// 'type == 2' indicates this batch is finished
321+
if (type == 3) {
322+
// 'type == 3' indicates this batch is finished
314323
resultSchemaTree.mergeSchemaTree(deserializer.finish());
315324
}
316325
} else {

iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/execution/operator/schema/SchemaFetchScanOperatorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,15 +101,15 @@ public void testSchemaFetchResult() throws Exception {
101101
Binary binary = tsBlock.getColumn(0).getBinary(0);
102102
InputStream inputStream = new ByteArrayInputStream(binary.getValues());
103103
if (!deserializer.isFirstBatch()) {
104-
Assert.assertEquals(1, type);
104+
Assert.assertEquals(2, type);
105105
}
106106
type = ReadWriteIOUtils.readByte(inputStream);
107107
if (deserializer.isFirstBatch()) {
108108
ReadWriteIOUtils.readLong(inputStream);
109109
}
110110
deserializer.deserializeFromBatch(inputStream);
111111
}
112-
Assert.assertEquals(2, type);
112+
Assert.assertEquals(3, type);
113113
Assert.assertFalse(schemaFetchScanOperator.hasNext());
114114
ClusterSchemaTree schemaTree = deserializer.finish();
115115

0 commit comments

Comments
 (0)