Fix datanode unit test failures

Author: Caideyipi

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/IoTDBInternalLocalReporter.java

@@ -86,8 +86,8 @@ public class IoTDBInternalLocalReporter extends IoTDBInternalReporter {
       "Failed to update the value of metric because of connection failure, because ";
   private static final String UPDATE_METRIC_INTERNAL_FAILURE =
       "Failed to update the value of metric because of internal error, because ";
-  private static final SessionManager SESSION_MANAGER = SessionManager.getInstance();
-  private static final Coordinator COORDINATOR = Coordinator.getInstance();
+  private final SessionManager sessionManager;
+  private final Coordinator coordinator;
   private final SessionInfo sessionInfo;
   private final IPartitionFetcher partitionFetcher;
   private final ISchemaFetcher schemaFetcher;
@@ -103,6 +103,8 @@ public class IoTDBInternalLocalReporter extends IoTDBInternalReporter {
       new ConcurrentHashMap<>();
 
   public IoTDBInternalLocalReporter() {
+    sessionManager = SessionManager.getInstance();
+    coordinator = Coordinator.getInstance();
     partitionFetcher = ClusterPartitionFetcher.getInstance();
     schemaFetcher = ClusterSchemaFetcher.getInstance();
     sessionInfo =
@@ -223,9 +225,9 @@ private TSStatus insertRecord(Map<String, Object> valueMap, String prefix, long
     request.setIsAligned(false);
 
     InsertRowStatement s = StatementGenerator.createStatement(request);
-    final long queryId = SESSION_MANAGER.requestQueryId();
+    final long queryId = sessionManager.requestQueryId();
     ExecutionResult result =
-        COORDINATOR.executeForTreeModel(
+        coordinator.executeForTreeModel(
             s, queryId, sessionInfo, "", partitionFetcher, schemaFetcher);
     return result.status;
   }
@@ -251,10 +253,10 @@ private void createTimeSeries(Map<String, Object> valueMap, String prefix)
     request.setEncodings(encodings);
     request.setCompressors(compressors);
     CreateMultiTimeSeriesStatement s = StatementGenerator.createStatement(request);
-    final long queryId = SESSION_MANAGER.requestQueryId();
+    final long queryId = sessionManager.requestQueryId();
 
     ExecutionResult result =
-        COORDINATOR.executeForTreeModel(
+        coordinator.executeForTreeModel(
             s, queryId, sessionInfo, "", partitionFetcher, schemaFetcher);
     if (result.status.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
       logAutoCreateTimeseriesFailureIfNecessary(prefix, paths, result.status);

iotdb-core/datanode/src/test/java/org/apache/iotdb/db/auth/LoginLockManagerTest.java

@@ -22,6 +22,7 @@
 import org.apache.iotdb.db.auth.LoginLockManager.UserLockInfo;
 import org.apache.iotdb.db.i18n.DataNodeMiscMessages;
 
+import ch.qos.logback.classic.Level;
 import ch.qos.logback.classic.spi.ILoggingEvent;
 import ch.qos.logback.core.read.ListAppender;
 import org.junit.Before;
@@ -149,6 +150,8 @@ public void testIpLockAfterMaxAttempts() {
   public void testLockMessagesLoggedOnlyWhenThresholdFirstReached() {
     ch.qos.logback.classic.Logger logger =
         (ch.qos.logback.classic.Logger) LoggerFactory.getLogger(LoginLockManager.class);
+    Level previousLevel = logger.getLevel();
+    logger.setLevel(Level.INFO);
     ListAppender<ILoggingEvent> appender = new ListAppender<>();
     appender.setContext(logger.getLoggerContext());
     appender.start();
@@ -163,6 +166,7 @@ public void testLockMessagesLoggedOnlyWhenThresholdFirstReached() {
       assertEquals(1, countLogEvents(appender, "User ID '{}' locked due to {} failed attempts"));
     } finally {
       logger.detachAppender(appender);
+      logger.setLevel(previousLevel);
       appender.stop();
     }
   }
@@ -171,6 +175,8 @@ public void testLockMessagesLoggedOnlyWhenThresholdFirstReached() {
   public void testPotentialAttackWarningsLoggedOnlyOnceWhileThresholdExceeded() {
     ch.qos.logback.classic.Logger logger =
         (ch.qos.logback.classic.Logger) LoggerFactory.getLogger(LoginLockManager.class);
+    Level previousLevel = logger.getLevel();
+    logger.setLevel(Level.INFO);
     ListAppender<ILoggingEvent> appender = new ListAppender<>();
     appender.setContext(logger.getLoggerContext());
     appender.start();
@@ -195,6 +201,7 @@ public void testPotentialAttackWarningsLoggedOnlyOnceWhileThresholdExceeded() {
       assertEquals(1, countLogEvents(appender, DataNodeMiscMessages.USER_MULTIPLE_IP_LOCKS));
     } finally {
       logger.detachAppender(appender);
+      logger.setLevel(previousLevel);
       appender.stop();
     }
   }

iotdb-core/datanode/src/test/java/org/apache/iotdb/db/conf/directories/strategy/DirectoryStrategyTest.java

@@ -155,8 +155,7 @@ public void testMinFolderOccupiedSpaceFirstStrategy()
   }
 
   @Test
-  public void testMinFolderOccupiedSpaceFirstStrategyLogThrottle()
-      throws DiskSpaceInsufficientException, IOException {
+  public void testMinFolderOccupiedSpaceFirstStrategyLogThrottle() throws Exception {
     MinFolderOccupiedSpaceFirstStrategy minFolderOccupiedSpaceFirstStrategy =
         new MinFolderOccupiedSpaceFirstStrategy();
     minFolderOccupiedSpaceFirstStrategy.setFolders(dataDirList);
@@ -171,17 +170,17 @@ public void testMinFolderOccupiedSpaceFirstStrategyLogThrottle()
     logger.addAppender(appender);
 
     try {
-      PowerMockito.when(JVMCommonUtils.getOccupiedSpace(dataDirList.get(0)))
-          .thenThrow(new IOException("broken occupied space"));
+      PowerMockito.doThrow(new IOException("broken occupied space"))
+          .when(JVMCommonUtils.class, "getOccupiedSpace", dataDirList.get(0));
       assertEquals(2, minFolderOccupiedSpaceFirstStrategy.nextFolderIndex());
       assertEquals(2, minFolderOccupiedSpaceFirstStrategy.nextFolderIndex());
       assertEquals(1, countLogEvents(appender, UtilMessages.CANNOT_CALCULATE_OCCUPIED_SPACE));
 
-      PowerMockito.when(JVMCommonUtils.getOccupiedSpace(dataDirList.get(0))).thenReturn(0L);
+      PowerMockito.doReturn(0L).when(JVMCommonUtils.class, "getOccupiedSpace", dataDirList.get(0));
       assertEquals(0, minFolderOccupiedSpaceFirstStrategy.nextFolderIndex());
 
-      PowerMockito.when(JVMCommonUtils.getOccupiedSpace(dataDirList.get(0)))
-          .thenThrow(new IOException("broken occupied space again"));
+      PowerMockito.doThrow(new IOException("broken occupied space again"))
+          .when(JVMCommonUtils.class, "getOccupiedSpace", dataDirList.get(0));
       assertEquals(2, minFolderOccupiedSpaceFirstStrategy.nextFolderIndex());
       assertEquals(2, countLogEvents(appender, UtilMessages.CANNOT_CALCULATE_OCCUPIED_SPACE));
     } finally {
@@ -254,8 +253,12 @@ public void testAllDiskFull() {
   }
 
   private long countLogEvents(ListAppender<ILoggingEvent> appender, String messagePattern) {
-    return appender.list.stream()
-        .filter(event -> messagePattern.equals(event.getMessage()))
-        .count();
+    long count = 0;
+    for (ILoggingEvent event : appender.list) {
+      if (messagePattern.equals(event.getMessage())) {
+        count++;
+      }
+    }
+    return count;
   }
 }

iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNodeTest.java

@@ -333,7 +333,7 @@ public void testConcurrentCheckpoint() throws Exception {
   @Test
   public void testDeleteOutdatedFiles() throws Exception {
     List<WALFlushListener> walFlushListeners = new ArrayList<>();
-    // write until log is rolled
+    // Write entries, then roll explicitly so the next active memTable starts in a new WAL file.
     long time = 0;
     IMemTable memTable = new PrimitiveMemTable(databasePath, dataRegionId);
     long memTableId = memTable.getMemTableId();
@@ -352,7 +352,7 @@ public void testDeleteOutdatedFiles() throws Exception {
         .setDataRegion(
             new DataRegionId(1), new DataRegionTest.DummyDataRegion(logDirectory, databasePath));
     walNode.onMemTableCreated(memTable, tsFilePath);
-    while (time < 20000) {
+    while (time < 10) {
       ++time;
       InsertTabletNode insertTabletNode =
           getInsertTabletNode(devicePath + memTableId, new long[] {time});
@@ -364,6 +364,7 @@ public void testDeleteOutdatedFiles() throws Exception {
       walFlushListeners.add(walFlushListener);
     }
     walNode.onMemTableFlushed(memTable);
+    walNode.rollWALFile();
     walNode.onMemTableCreated(new PrimitiveMemTable(databasePath, dataRegionId), tsFilePath);
     Awaitility.await().until(() -> walNode.isAllWALEntriesConsumed());
     // check existence of _0-0-0.wal file and _1-0-1.wal file