Fix code structure

Author: YangYumings

iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java

@@ -1774,12 +1774,7 @@ private boolean filterNullValueAndMeasurement(
     return false;
   }
 
-  /**
-   * Filter the null object of list。
-   *
-   * @param prefixPaths devices path。
-   * @return true:all values of valuesList are null;false:Not all values of valuesList are null.
-   */
+  /** Filter the null object of list。 */
   private void filterNullValueAndMeasurementWithStringType(
       List<String> prefixPaths,
       List<Long> times,

iotdb-client/session/src/main/java/org/apache/iotdb/session/rpccompress/decoder/RleColumnDecoder.java

@@ -41,21 +41,20 @@ public RleColumnDecoder(TSDataType dataType) {
   public Object decode(ByteBuffer buffer, ColumnEntry columnEntry, int rowCount) {
     switch (dataType) {
       case BOOLEAN:
-        return decoder.readBoolean(buffer);
+        return decodeBooleanColumn(buffer, columnEntry, rowCount);
       case INT32:
       case DATE:
-        return decoder.readInt(buffer);
+        return decodeIntColumn(buffer, columnEntry, rowCount);
       case INT64:
       case TIMESTAMP:
-        return decoder.readLong(buffer);
+        return decodeLongColumn(buffer, columnEntry, rowCount);
       case FLOAT:
-        return decoder.readFloat(buffer);
+        return decodeFloatColumn(buffer, columnEntry, rowCount);
       case DOUBLE:
-        return decoder.readDouble(buffer);
+        return decodeDoubleColumn(buffer, columnEntry, rowCount);
       case TEXT:
       case STRING:
       case BLOB:
-        return decoder.readBinary(buffer);
       default:
         throw new UnsupportedOperationException("PLAIN doesn't support data type: " + dataType);
     }

iotdb-client/session/src/main/java/org/apache/iotdb/session/rpccompress/decoder/ZigzagColumnDecoder.java

@@ -54,8 +54,7 @@ public Object decode(ByteBuffer buffer, ColumnEntry columnEntry, int rowCount) {
 
   @Override
   public boolean[] decodeBooleanColumn(ByteBuffer buffer, ColumnEntry columnEntry, int rowCount) {
-    throw new TsFileDecodingException(
-        String.format("Zigzag doesn't support data type: " + dataType));
+    throw new TsFileDecodingException("Zigzag doesn't support data type: " + dataType);
   }
 
   @Override

iotdb-client/session/src/main/java/org/apache/iotdb/session/rpccompress/encoder/ColumnEncoder.java

@@ -54,7 +54,6 @@ public interface ColumnEncoder {
    * number of entries.
    *
    * @param len the length of arrayList
-   * @return
    */
   default int getUncompressedDataSize(int len, Binary[] values, TSDataType dataType) {
     int unCompressedSize = 0;

iotdb-client/session/src/main/java/org/apache/iotdb/session/rpccompress/encoder/PlainColumnEncoder.java

@@ -49,8 +49,8 @@ public PlainColumnEncoder(TSDataType dataType) {
   /**
    * Encodes a column of data using the PLAIN encoding algorithm.
    *
-   * @param values
-   * @param out
+   * @param values values the input boolean array to be encoded
+   * @param out out the output stream to write the encoded binary data
    */
   @Override
   public void encode(boolean[] values, ByteArrayOutputStream out) {
@@ -193,8 +193,8 @@ public void encode(Binary[] values, ByteArrayOutputStream out) {
   /**
    * Set column entry metadata
    *
-   * @param compressedSize
-   * @param unCompressedSize
+   * @param compressedSize the size of the encoded data in bytes after compression
+   * @param unCompressedSize the original size of the data in bytes before compression
    */
   private void setColumnEntry(Integer compressedSize, Integer unCompressedSize) {
     columnEntry = new ColumnEntry(compressedSize, unCompressedSize, dataType, TSEncoding.PLAIN);

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/handler/RPCServiceThriftHandlerMetrics.java

@@ -37,14 +37,11 @@ public class RPCServiceThriftHandlerMetrics implements IMetricSet {
 
   // region begin
   private Timer compressionRatioTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
-  private Timer timeConsumedOfRPCTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
-  private Timer encodeLatencyTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
   private Timer decodeLatencyTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
-  private Timer compressLatencyTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
   private Timer decompressLatencyTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
 
   // end
-
+  // 内存占用
   public RPCServiceThriftHandlerMetrics(AtomicLong thriftConnectionNumber) {
     this.thriftConnectionNumber = thriftConnectionNumber;
   }
@@ -53,22 +50,10 @@ public void recordCompressionRatioTimer(final long costTimeInNanos) {
     compressionRatioTimer.update(costTimeInNanos, TimeUnit.NANOSECONDS);
   }
 
-  public void recordTimeConsumedOfRPC(final long costTimeInNanos) {
-    timeConsumedOfRPCTimer.update(costTimeInNanos, TimeUnit.NANOSECONDS);
-  }
-
-  public void recordEncodeLatencyTimer(final long costTimeInNanos) {
-    encodeLatencyTimer.update(costTimeInNanos, TimeUnit.NANOSECONDS);
-  }
-
   public void recordDecodeLatencyTimer(final long costTimeInNanos) {
     decodeLatencyTimer.update(costTimeInNanos, TimeUnit.NANOSECONDS);
   }
 
-  public void recordCompressLatencyTimer(final long costTimeInNanos) {
-    compressLatencyTimer.update(costTimeInNanos, TimeUnit.NANOSECONDS);
-  }
-
   public void recordDecompressLatencyTimer(final long costTimeInNanos) {
     decompressLatencyTimer.update(costTimeInNanos, TimeUnit.NANOSECONDS);
   }
@@ -94,34 +79,13 @@ private void bindToTimer(final AbstractMetricService metricService) {
             Tag.NAME.toString(),
             "compressionRatio");
 
-    timeConsumedOfRPCTimer =
-        metricService.getOrCreateTimer(
-            Metric.THRIFT_RPC_COMPRESS.toString(),
-            MetricLevel.IMPORTANT,
-            Tag.NAME.toString(),
-            "timeConsumedOfRPC");
-
-    encodeLatencyTimer =
-        metricService.getOrCreateTimer(
-            Metric.THRIFT_RPC_COMPRESS.toString(),
-            MetricLevel.IMPORTANT,
-            Tag.NAME.toString(),
-            "encodeLatency");
-
     decodeLatencyTimer =
         metricService.getOrCreateTimer(
             Metric.THRIFT_RPC_COMPRESS.toString(),
             MetricLevel.IMPORTANT,
             Tag.NAME.toString(),
             "decodeLatency");
 
-    compressLatencyTimer =
-        metricService.getOrCreateTimer(
-            Metric.THRIFT_RPC_COMPRESS.toString(),
-            MetricLevel.IMPORTANT,
-            Tag.NAME.toString(),
-            "compressLatency");
-
     decompressLatencyTimer =
         metricService.getOrCreateTimer(
             Metric.THRIFT_RPC_COMPRESS.toString(),
@@ -139,10 +103,7 @@ public void unbindFrom(AbstractMetricService metricService) {
         "ClientRPC");
 
     compressionRatioTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
-    timeConsumedOfRPCTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
-    encodeLatencyTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
     decodeLatencyTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
-    compressLatencyTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
     decompressLatencyTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
 
     metricService.remove(

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/StatementGenerator.java

@@ -549,7 +549,7 @@ public static InsertRowsOfOneDeviceStatement createStatement(TSInsertRecordsOfOn
     insertStatement.setDevicePath(DEVICE_PATH_CACHE.getPartialPath(req.prefixPath));
     List<InsertRowStatement> insertRowStatementList = new ArrayList<>();
     // req.timestamps sorted on session side
-    if (req.timestamps.size() != 0) {
+    if (!req.timestamps.isEmpty()) {
       TimestampPrecisionUtils.checkTimestampPrecision(
           req.timestamps.get(req.timestamps.size() - 1));
     }