Fix C++ client tablet bounds and session close semantics (#18005)

Add boundary checks for Tablet addTimestamp/addValue and validate ts_tablet_set_row_count to prevent rowSize from exceeding maxRowNumber. Align Session::close with Java by closing connections and routing all operations through getDefaultSessionConnection(). Map C API out_of_range to TS_ERR_INVALID_PARAM and add regression tests.

Author: hongzhi-gao

iotdb-client/client-cpp/src/include/Session.h

@@ -232,6 +232,14 @@ class Tablet {
   }
 
   void addTimestamp(size_t rowIndex, int64_t timestamp) {
+    if (rowIndex >= static_cast<size_t>(maxRowNumber)) {
+      char tmpStr[100];
+      snprintf(tmpStr, sizeof(tmpStr),
+               "Tablet::addTimestamp(), rowIndex >= maxRowNumber. rowIndex=%ld, "
+               "maxRowNumber=%ld.",
+               (long)rowIndex, (long)maxRowNumber);
+      throw std::out_of_range(tmpStr);
+    }
     timestamps[rowIndex] = timestamp;
     rowSize = max(rowSize, rowIndex + 1);
   }
@@ -248,10 +256,18 @@ class Tablet {
       throw std::out_of_range(tmpStr);
     }
 
-    if (rowIndex >= rowSize) {
+    if (rowIndex >= static_cast<size_t>(maxRowNumber)) {
+      char tmpStr[100];
+      snprintf(tmpStr, sizeof(tmpStr),
+               "Tablet::addValue(), rowIndex >= maxRowNumber. rowIndex=%ld, maxRowNumber=%ld.",
+               (long)rowIndex, (long)maxRowNumber);
+      throw std::out_of_range(tmpStr);
+    }
+
+    if (rowIndex >= static_cast<size_t>(rowSize)) {
       char tmpStr[100];
       snprintf(tmpStr, sizeof(tmpStr),
-               "Tablet::addValue(), rowIndex >= rowSize. rowIndex=%ld, rowSize.size()=%ld.",
+               "Tablet::addValue(), rowIndex >= rowSize. rowIndex=%ld, rowSize=%ld.",
                (long)rowIndex, (long)rowSize);
       throw std::out_of_range(tmpStr);
     }

iotdb-client/client-cpp/src/rpc/SessionImpl.h

@@ -60,6 +60,13 @@ class Session::Impl {
   std::shared_ptr<INodesSupplier> nodesSupplier_;
   std::shared_ptr<SessionConnection> defaultSessionConnection_;
 
+  std::shared_ptr<SessionConnection> getDefaultSessionConnection() {
+    if (isClosed_ || !defaultSessionConnection_) {
+      throw IoTDBConnectionException("Session is not open, please invoke Session.open() first");
+    }
+    return defaultSessionConnection_;
+  }
+
   TEndPoint defaultEndPoint_;
 
   struct TEndPointHash {
@@ -168,7 +175,7 @@ void Session::Impl::insertByGroup(
         if (endPointToSessionConnection.size() > 1) {
           removeBrokenSessionConnection(connection);
           try {
-            insertConsumer(defaultSessionConnection_, req);
+            insertConsumer(getDefaultSessionConnection(), req);
           } catch (const RedirectException&) {
           }
         } else {
@@ -216,7 +223,7 @@ void Session::Impl::insertOnce(
     if (endPointToSessionConnection.size() > 1) {
       removeBrokenSessionConnection(connection);
       try {
-        insertConsumer(defaultSessionConnection_, req);
+        insertConsumer(getDefaultSessionConnection(), req);
       } catch (const RedirectException&) {
       }
     } else {