Skip to content

perf: Optimize the mark bitmap operation of AlignedTVList InsertTablet#16199

Merged
jt2594838 merged 8 commits into
apache:masterfrom
luoluoyuyu:opt-insert
Aug 27, 2025
Merged

perf: Optimize the mark bitmap operation of AlignedTVList InsertTablet#16199
jt2594838 merged 8 commits into
apache:masterfrom
luoluoyuyu:opt-insert

Conversation

@luoluoyuyu

@luoluoyuyu luoluoyuyu commented Aug 18, 2025

Copy link
Copy Markdown
Member

Description

Objective

Optimize the markNullValue function when writing multiple columns into a TVList using the InsertNode type.

Implementation:

  1. Optimize column-first, row-last traversal to improve CPU cache efficiency.
  2. Provide a wide range of mark BitMap operations.
  3. Move the result array out of the BitMap to reduce CPU computation.

Implementation Results

Optimized results for a scenario where a tree model with 10,000 aligned columns only writes 15 columns at a time.
image
image


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@luoluoyuyu luoluoyuyu marked this pull request as draft August 18, 2025 10:38
@luoluoyuyu luoluoyuyu marked this pull request as ready for review August 19, 2025 08:01
@jt2594838 jt2594838 merged commit 51fe585 into apache:master Aug 27, 2025
33 of 34 checks passed
@luoluoyuyu luoluoyuyu deleted the opt-insert branch September 9, 2025 08:41
luoluoyuyu added a commit to luoluoyuyu/iotdb that referenced this pull request Oct 15, 2025
Caideyipi pushed a commit that referenced this pull request Oct 16, 2025
JackieTien97 pushed a commit that referenced this pull request Dec 16, 2025
#16199)

* perf: Optimize the mark bitmap operation of AlignedTVList InsertTablet

* add UT

* update

* fix

* fix

* update tsfile version

* fix

(cherry picked from commit 51fe585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants