Skip to content

Fix nested transformer close and move shared classes#17642

Merged
JackieTien97 merged 2 commits into
masterfrom
fixBugsAndMoveCommonClass
May 12, 2026
Merged

Fix nested transformer close and move shared classes#17642
JackieTien97 merged 2 commits into
masterfrom
fixBugsAndMoveCommonClass

Conversation

@shuwenwei

@shuwenwei shuwenwei commented May 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Propagate ColumnTransformer close calls through nested transformer parents so UDF transformers are closed when nested.
  • Move shared query queue and relational metadata classes into common modules to avoid follow-up code conflicts.
  • Move TableDiskUsageIndex close after all services are stopped to avoid shutting down the shared index while services may still access it.

Propagate ColumnTransformer close calls through nested parent transformers.

Move shared query queue and relational metadata classes into common modules to reduce downstream conflicts.
@shuwenwei shuwenwei marked this pull request as ready for review May 12, 2026 07:46
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.50000% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.36%. Comparing base (9348cb8) to head (53d7364).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../column/AbstractCaseWhenThenColumnTransformer.java 0.00% 7 Missing ⚠️
...n/dag/column/ternary/TernaryColumnTransformer.java 0.00% 5 Missing ⚠️
...dag/column/multi/MappableUDFColumnTransformer.java 0.00% 3 Missing ⚠️
...ation/dag/column/unary/UnaryColumnTransformer.java 0.00% 3 Missing ⚠️
...ain/java/org/apache/iotdb/db/service/DataNode.java 0.00% 1 Missing ⚠️
...ction/execute/exception/StopTTLCheckException.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17642      +/-   ##
============================================
+ Coverage     40.34%   40.36%   +0.02%     
- Complexity     2554     2574      +20     
============================================
  Files          5177     5178       +1     
  Lines        348975   348898      -77     
  Branches      44655    44636      -19     
============================================
+ Hits         140778   140819      +41     
+ Misses       208197   208079     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97 JackieTien97 merged commit ed7f4d7 into master May 12, 2026
40 of 43 checks passed
@JackieTien97 JackieTien97 deleted the fixBugsAndMoveCommonClass branch May 12, 2026 10:23
VGalaxies pushed a commit to VGalaxies/iotdb that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants