Skip to content

[to dev/1.3] Fix nested ColumnTransformer close#17643

Merged
JackieTien97 merged 1 commit into
dev/1.3from
fixBugs0512-1.3
May 12, 2026
Merged

[to dev/1.3] Fix nested ColumnTransformer close#17643
JackieTien97 merged 1 commit into
dev/1.3from
fixBugs0512-1.3

Conversation

@shuwenwei
Copy link
Copy Markdown
Member

@shuwenwei shuwenwei commented May 12, 2026

Summary

  • Propagate ColumnTransformer close calls through unary, binary, ternary, CASE WHEN, and mappable UDF transformer parents.
  • Ensure nested UDF transformers are closed when wrapped by expression transformers.

Propagate close calls through nested ColumnTransformer parents so UDF transformers are closed when wrapped by expressions.
@shuwenwei shuwenwei marked this pull request as ready for review May 12, 2026 08:10
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.00%. Comparing base (6a1961b) to head (5293cc3).

Files with missing lines Patch % Lines
...tion/dag/column/CaseWhenThenColumnTransformer.java 0.00% 7 Missing ⚠️
...n/dag/column/ternary/TernaryColumnTransformer.java 0.00% 5 Missing ⚠️
...ion/dag/column/binary/BinaryColumnTransformer.java 0.00% 4 Missing ⚠️
...dag/column/multi/MappableUDFColumnTransformer.java 0.00% 3 Missing ⚠️
...ation/dag/column/unary/UnaryColumnTransformer.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #17643      +/-   ##
=============================================
- Coverage      42.00%   42.00%   -0.01%     
  Complexity       241      241              
=============================================
  Files           3612     3612              
  Lines         238367   238389      +22     
  Branches       28964    28966       +2     
=============================================
- Hits          100126   100125       -1     
- Misses        138241   138264      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97 JackieTien97 merged commit f3b83aa into dev/1.3 May 12, 2026
13 of 14 checks passed
@JackieTien97 JackieTien97 deleted the fixBugs0512-1.3 branch May 12, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants