Skip to content

[To dev/1.3] Load: Harden LOAD TSFILE source path validation (#17624)#17654

Merged
jt2594838 merged 4 commits into
dev/1.3from
ger-shop-2
May 13, 2026
Merged

[To dev/1.3] Load: Harden LOAD TSFILE source path validation (#17624)#17654
jt2594838 merged 4 commits into
dev/1.3from
ger-shop-2

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.15385% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.03%. Comparing base (f3b83aa) to head (83def90).
⚠️ Report is 1 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
...ngine/plan/statement/crud/LoadTsFileStatement.java 58.06% 13 Missing ⚠️
...ain/java/org/apache/iotdb/db/conf/IoTDBConfig.java 75.55% 11 Missing ⚠️
...rageengine/load/active/ActiveLoadTsFileLoader.java 0.00% 2 Missing ⚠️
.../receiver/protocol/legacy/loader/TsFileLoader.java 0.00% 1 Missing ⚠️
...eceiver/protocol/thrift/IoTDBDataNodeReceiver.java 0.00% 1 Missing ⚠️
...ryengine/plan/analyze/load/LoadTsFileAnalyzer.java 0.00% 1 Missing ⚠️
...ngine/plan/scheduler/load/LoadTsFileScheduler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #17654      +/-   ##
=============================================
+ Coverage      42.00%   42.03%   +0.02%     
  Complexity       241      241              
=============================================
  Files           3612     3612              
  Lines         238389   238488      +99     
  Branches       28966    28974       +8     
=============================================
+ Hits          100145   100237      +92     
- Misses        138244   138251       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838 jt2594838 merged commit 5ec7ee2 into dev/1.3 May 13, 2026
18 of 20 checks passed
@jt2594838 jt2594838 deleted the ger-shop-2 branch May 13, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants