Load: Optimized the downgraded logic for tsFile to insert more data when tsFile corrupted#17674
Conversation
luoluoyuyu
left a comment
There was a problem hiding this comment.
Review summary
Introduces LoadTreeTsFileTabletIterator and uses it in LoadTreeStatementDataTypeConvertExecutionVisitor so corrupted TsFiles can yield more insertable tablets on downgrade. Adds unit tests for the converter path.
Please fix failing datanode unit tests before merge.
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTreeStatementDataTypeConvertExecutionVisitor.java
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17674 +/- ##
============================================
+ Coverage 40.87% 41.31% +0.43%
+ Complexity 2611 318 -2293
============================================
Files 5186 5273 +87
Lines 351308 368255 +16947
Branches 44971 47655 +2684
============================================
+ Hits 143585 152131 +8546
- Misses 207723 216124 +8401 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
* Load: Optimized the downgraded logic for tsFile to insert more data when tsFile corrupted (#17674) * down * Update LoadTreeStatementDataTypeConvertExecutionVisitorTest.java * Fix query parser deferred tablet failure handling * Fix aligned load fallback corruption test * Address load fallback review comments (cherry picked from commit cb97fe4) * Update LoadTreeStatementDataTypeConvertExecutionVisitorTest.java * Update LoadTreeStatementDataTypeConvertExecutionVisitorTest.java
…hen tsFile corrupted (apache#17674) * down * Update LoadTreeStatementDataTypeConvertExecutionVisitorTest.java * Fix query parser deferred tablet failure handling * Fix aligned load fallback corruption test * Address load fallback review comments




Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR