Skip to content

Load: Optimized the downgraded logic for tsFile to insert more data when tsFile corrupted#17674

Merged
jt2594838 merged 6 commits into
masterfrom
load-query
Jun 23, 2026
Merged

Load: Optimized the downgraded logic for tsFile to insert more data when tsFile corrupted#17674
jt2594838 merged 6 commits into
masterfrom
load-query

Address load fallback review comments

a3e00d5
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 22, 2026 in 2m 41s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 275 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTreeTsFileTabletIterator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ7uoz3G8fB74yYqVBQu&open=AZ7uoz3G8fB74yYqVBQu&pullRequest=17674

Check warning on line 92 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTreeTsFileTabletIterator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code so that the Iterator supports multiple traversal 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ7uoz3G8fB74yYqVBQt&open=AZ7uoz3G8fB74yYqVBQt&pullRequest=17674

Check warning on line 376 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ7uoz8B8fB74yYqVBQw&open=AZ7uoz8B8fB74yYqVBQw&pullRequest=17674

Check warning on line 397 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTreeTsFileTabletIterator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof RuntimeException runtimeexception' 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ7uoz3G8fB74yYqVBQv&open=AZ7uoz3G8fB74yYqVBQv&pullRequest=17674

Check warning on line 451 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/scan/TsFileInsertionEventScanParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 134 to 64, Complexity from 34 to 14, Nesting Level from 4 to 2, Number of Variables from 8 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ7uoz8B8fB74yYqVBQx&open=AZ7uoz8B8fB74yYqVBQx&pullRequest=17674

Check warning on line 145 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTreeTsFileTabletIterator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ7uoz3G8fB74yYqVBQs&open=AZ7uoz3G8fB74yYqVBQs&pullRequest=17674

Check warning on line 154 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/query/TsFileInsertionEventQueryParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Constructor has 13 parameters, which is greater than 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ7uoz8Z8fB74yYqVBQy&open=AZ7uoz8Z8fB74yYqVBQy&pullRequest=17674
View more details on SonarQubeCloud