Fix query TVList snapshot race during working memtable reads#17699
Closed
shuwenwei wants to merge 1 commit into
Closed
Fix query TVList snapshot race during working memtable reads#17699shuwenwei wants to merge 1 commit into
shuwenwei wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Root Cause
The query context lock only protects query ownership metadata, not TVList row count, sorted state, writes, or sort operations. A query could share a currently sorted mutable working TVList while recording a row count from a different moment, allowing a later query sort to reorder indices used by an older iterator.
Validation
Not run, per local workflow instruction.