Skip to content

Fix alter pipe password check after restart for write-back sink. #17771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luoluoyuyu wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −3
Open

Fix alter pipe password check after restart for write-back sink. #17771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebf7ebe
Fix alter pipe password check after restart for write-back sink.
luoluoyuyu May 26, 2026
6b40e9a
spotless
luoluoyuyu May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions iotdb-core/datanode/src/main/java/org/apache/iotdb/db/auth/LoginLockManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,11 @@ public void cleanExpiredLocks() {
// Remove outdated failures
info.removeOldFailures(cutoffTime);
if (info.getFailureCount() == 0) {
String[] parts = entry.getKey().split("@");
LOGGER.info(DataNodeMiscMessages.IP_UNLOCKED_EXPIRED, parts[1], parts[0]);
final String[] parts = entry.getKey().split("@", 2);
LOGGER.info(
DataNodeMiscMessages.IP_UNLOCKED_EXPIRED,
parts.length == 2 ? parts[1] : "",
parts.length >= 1 ? parts[0] : "");
return true;
}
return false;
Expand Down
6 changes: 5 additions & 1 deletion iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/session/SessionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import org.apache.iotdb.rpc.TSStatusCode;
import org.apache.iotdb.service.rpc.thrift.TSConnectionInfo;
import org.apache.iotdb.service.rpc.thrift.TSConnectionInfoResp;
import org.apache.iotdb.service.rpc.thrift.TSConnectionType;
import org.apache.iotdb.service.rpc.thrift.TSProtocolVersion;

import org.apache.tsfile.external.commons.lang3.StringUtils;
Expand Down Expand Up @@ -138,7 +139,10 @@ public BasicOpenSessionResp login(

final long userId = AuthorityChecker.getUserId(username).orElse(-1L);

boolean enableLoginLock = userId != -1;
// Pipe/CQ/Select-Into use InternalClientSession for password validation and should not
// participate in user@ip login lock (empty client address shares one lock bucket).
final boolean enableLoginLock =
userId != -1 && session.getConnectionType() != TSConnectionType.INTERNAL;
LoginLockManager loginLockManager = LoginLockManager.getInstance();
if (enableLoginLock && loginLockManager.checkLock(userId, session.getClientAddress())) {
// Generic authentication error
Expand Down
Loading