Skip to content

[AINode] Remove Chronos2 DataLoader pin_memory option#17822

Merged
CRZbulabula merged 1 commit into
masterfrom
fix-chronos2-pin-memory
Jun 3, 2026
Merged

[AINode] Remove Chronos2 DataLoader pin_memory option#17822
CRZbulabula merged 1 commit into
masterfrom
fix-chronos2-pin-memory

Conversation

@CRZbulabula

@CRZbulabula CRZbulabula commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Remove the deprecated pin_memory argument from the Chronos2 pipeline DataLoader.
  • Reuse BUILTIN_LTSM_MAP to cover every supported built-in large time series model.
  • For each supported model, verify loading to CPU, GPU, and CPU+GPU device sets.
  • After each load, run tree-model CALL INFERENCE and table-model FORECAST smoke queries, then unload and verify the model is no longer loaded.
  • Fix request-pool memory gating so CPU pools check available system memory instead of blocking once the model process RSS exceeds the threshold.

Tests

  • Ran formatter only: black/isort on the changed AINode Python file, and mvn spotless:apply -pl integration-test -P with-integration-tests.
  • Did not run local CI/tests; the pushed PR branch should trigger CI.

@CRZbulabula CRZbulabula force-pushed the fix-chronos2-pin-memory branch 2 times, most recently from 2e92dc7 to 3f1135d Compare June 3, 2026 01:44
@CRZbulabula CRZbulabula force-pushed the fix-chronos2-pin-memory branch from 3f1135d to a114d87 Compare June 3, 2026 02:29
@sonarqubecloud

sonarqubecloud Bot commented Jun 3, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.89%. Comparing base (99f0af1) to head (a114d87).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #17822      +/-   ##
============================================
- Coverage     40.90%   40.89%   -0.01%     
  Complexity     2610     2610              
============================================
  Files          5186     5186              
  Lines        351388   351420      +32     
  Branches      44991    44991              
============================================
- Hits         143722   143718       -4     
- Misses       207666   207702      +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CRZbulabula CRZbulabula changed the title Remove Chronos2 DataLoader pin_memory option [AINode] Remove Chronos2 DataLoader pin_memory option Jun 3, 2026
@CRZbulabula CRZbulabula merged commit e2322e9 into master Jun 3, 2026
45 of 51 checks passed
@CRZbulabula CRZbulabula deleted the fix-chronos2-pin-memory branch June 3, 2026 08:32
MileaRobertStefan pushed a commit to MileaRobertStefan/iotdb that referenced this pull request Jun 26, 2026
@CRZbulabula @robertMileaNi
[AINode] Remove Chronos2 DataLoader pin_memory option (apache#17822)
023926e
JackieTien97 pushed a commit that referenced this pull request Jun 29, 2026
@CRZbulabula @JackieTien97
[AINode] Remove Chronos2 DataLoader pin_memory option (#17822)
8da40c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@CRZbulabula