Fix table delete with renamed time column#17841
Merged
jt2594838 merged 2 commits intoJun 4, 2026
Merged
Conversation
Caideyipi
approved these changes
Jun 4, 2026
Caideyipi
left a comment
Caideyipi
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I did not find any functional issues in the production change.
MileaRobertStefan
pushed a commit
to MileaRobertStefan/iotdb
that referenced
this pull request
Jun 26, 2026
* reviewed AnalyzeUtils * Fix delete with non-default time column
JackieTien97
pushed a commit
that referenced
this pull request
Jun 29, 2026
* reviewed AnalyzeUtils * Fix delete with non-default time column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes table-model DELETE predicate parsing when the TIME column has been renamed. The deletion analyzer now resolves the actual TIME column name from table schema instead of assuming the default time column name.
It also adds i18n messages for the newly added semantic error and covers the renamed-time-column path in unit tests.
Tests
Note: Running IoTDBDeletionTableIT#testDeleteWithRenamedTimeColumn was attempted, but the test class failed in its shared setup/teardown before the case body due to CREATE/DROP DATABASE IF EXISTS test being parsed by the tree-model parser in this local environment.