Skip to content

Support constant folding for insert values#17850

Open
Caideyipi wants to merge 7 commits into
masterfrom
insert-values-constant-folding
Open

Support constant folding for insert values#17850
Caideyipi wants to merge 7 commits into
masterfrom
insert-values-constant-folding

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Summary

  • defer table-model INSERT VALUES materialization until analysis so values can reuse IrExpressionInterpreter constant folding
  • throw a readable SemanticException when an insert expression still is not constant after folding
  • add relational session coverage for folded INSERT VALUES expressions

Verification

  • mvn -pl iotdb-core/datanode spotless:check
  • mvn -pl integration-test spotless:check -P with-integration-tests
  • mvn -pl iotdb-core/datanode -DskipTests compile (fails in pre-existing generated aggregation sources: missing ComparatorChain / getModeMapSizeThreshold)

@Caideyipi
Caideyipi force-pushed the insert-values-constant-folding branch from 96ed42c to 88803de Compare June 5, 2026 04:08
@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.43056% with 281 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.39%. Comparing base (bd49457) to head (fa1dbaf).
⚠️ Report is 49 commits behind head on master.

Files with missing lines Patch % Lines
...ryengine/plan/relational/sql/ast/InsertValues.java 0.00% 142 Missing ⚠️
...an/relational/planner/IrExpressionInterpreter.java 5.82% 97 Missing ⚠️
.../queryengine/plan/relational/sql/util/AstUtil.java 0.00% 32 Missing ⚠️
...nner/plan/node/write/RelationalInsertRowsNode.java 0.00% 5 Missing ⚠️
...yengine/plan/relational/sql/parser/AstBuilder.java 0.00% 3 Missing ⚠️
...ne/plan/relational/analyzer/StatementAnalyzer.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17850      +/-   ##
============================================
+ Coverage     41.84%   42.39%   +0.54%     
- Complexity      318      343      +25     
============================================
  Files          5296     5355      +59     
  Lines        373604   379268    +5664     
  Branches      48232    49160     +928     
============================================
+ Hits         156351   160773    +4422     
- Misses       217253   218495    +1242     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Caideyipi
Caideyipi marked this pull request as draft June 9, 2026 07:23
Caideyipi added 3 commits June 9, 2026 16:29
…ant-folding

# Conflicts:
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java
@Caideyipi
Caideyipi marked this pull request as ready for review July 3, 2026 03:47
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant