Fix duplicate scheduling in procedure execution#17902
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17902 +/- ##
============================================
+ Coverage 41.15% 41.17% +0.02%
Complexity 318 318
============================================
Files 5258 5258
Lines 365613 365743 +130
Branches 47282 47300 +18
============================================
+ Hits 150460 150596 +136
+ Misses 215153 215147 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…cedure-duplicate-scheduling
jt2594838
reviewed
Jun 16, 2026
Comment on lines
+110
to
+115
| boolean duplicated = blockingProcedure.awaitExecution(3, TimeUnit.SECONDS); | ||
|
|
||
| blockingProcedure.releaseExecutions(duplicated ? 2 : 1); | ||
| ProcedureTestUtil.waitForProcedure(procExecutor, procId); | ||
|
|
||
| Assert.assertFalse(duplicated); |
Contributor
There was a problem hiding this comment.
line 112 is weird together with line 115.
|
MileaRobertStefan
pushed a commit
to MileaRobertStefan/iotdb
that referenced
this pull request
Jun 26, 2026
* Fix duplicate scheduling in procedure execution * Fix delayed procedure deduplication and semaphore release * Fix SQL parser error handler traversal * Fix pipe procedure lock release race * Fix procedure lock wait scheduling (cherry picked from commit c25849a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent duplicate procedure execution
Avoid duplicate lock wakeups
Tests
This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
Local verification