GH-2162: Add more detailed logging to upload errors.#4052
Open
ThomasThelen wants to merge 1 commit into
Open
Conversation
Member
|
Looks great and much more helpful to the user. It works for me in development (I have rebased to current main; suitable browser cache refresh to get the javascript) but the build is failing in tests, both on github (see the buld failure at "All checks have failed") and in a local build: Longer extract of build of jena-fuseki-ui: jena-fuseki-ui build log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #2162
Pull request Description:
This PR adds support for displaying Fuseki's error message, or a fallback if not present. The error message was already in an existing object; most of the lines of code are for the fallback.
Some of the fallback messages could be informative but I didn't want to prescribe too many solutions, miss others that I don't know about, etc. If any can be improved let me know.
Demo:
Screen.Recording.2026-07-07.at.7.26.20.PM.mov
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.