Skip to content

KAFKA-20194: Fix StoreBuilderWrapper for header-stores #21950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjsax merged 6 commits into from
Apr 7, 2026
Merged

KAFKA-20194: Fix StoreBuilderWrapper for header-stores #21950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9b3275
MINOR: Fix StoreBuilderWrapper for header-stores
mjsax Apr 3, 2026
c24dcc3
random fixes
mjsax Apr 3, 2026
d3678b9
fix incorrect test setup
mjsax Apr 3, 2026
900aa31
fix incorrect public method name
mjsax Apr 3, 2026
9b3c0f3
add new test
mjsax Apr 3, 2026
ea83248
fix method name for header-kv-store builder
mjsax Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...rc/test/java/org/apache/kafka/streams/integration/HeadersStoreUpgradeIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ private void shouldMigrateTimestampedKeyValueStoreToTimestampedKeyValueStoreWith
final StreamsBuilder streamsBuilderForNewStore = new StreamsBuilder();

streamsBuilderForNewStore.addStateStore(
Stores.timestampedKeyValueStoreBuilderWithHeaders(
Stores.timestampedKeyValueStoreWithHeadersBuilder(
persistentStore ? Stores.persistentTimestampedKeyValueStoreWithHeaders(STORE_NAME) : Stores.inMemoryKeyValueStore(STORE_NAME),
Serdes.String(),
Serdes.String()))
Expand Down Expand Up @@ -222,7 +222,7 @@ public void shouldProxyTimestampedKeyValueStoreToTimestampedKeyValueStoreWithHea
final StreamsBuilder streamsBuilderForNewStore = new StreamsBuilder();

streamsBuilderForNewStore.addStateStore(
Stores.timestampedKeyValueStoreBuilderWithHeaders(
Stores.timestampedKeyValueStoreWithHeadersBuilder(
Stores.persistentTimestampedKeyValueStore(STORE_NAME),
Serdes.String(),
Serdes.String()))
Expand Down Expand Up @@ -288,7 +288,7 @@ private void shouldMigratePlainKeyValueStoreToTimestampedKeyValueStoreWithHeader
final StreamsBuilder streamsBuilderForNewStore = new StreamsBuilder();

streamsBuilderForNewStore.addStateStore(
Stores.timestampedKeyValueStoreBuilderWithHeaders(
Stores.timestampedKeyValueStoreWithHeadersBuilder(
persistentStore ? Stores.persistentTimestampedKeyValueStoreWithHeaders(STORE_NAME) : Stores.inMemoryKeyValueStore(STORE_NAME),
Serdes.String(),
Serdes.String()))
Expand Down Expand Up @@ -341,7 +341,7 @@ public void shouldProxyPlainKeyValueStoreToTimestampedKeyValueStoreWithHeadersUs
final StreamsBuilder streamsBuilderForNewStore = new StreamsBuilder();

streamsBuilderForNewStore.addStateStore(
Stores.timestampedKeyValueStoreBuilderWithHeaders(
Stores.timestampedKeyValueStoreWithHeadersBuilder(
Stores.persistentKeyValueStore(STORE_NAME),
Serdes.String(),
Serdes.String()))
Expand Down Expand Up @@ -1563,7 +1563,7 @@ private void produceRecordWithHeaders(final String key, final String value, fina
private void setupAndPopulateKeyValueStoreWithHeaders(final Properties props) throws Exception {
final StreamsBuilder headersBuilder = new StreamsBuilder();
headersBuilder.addStateStore(
Stores.timestampedKeyValueStoreBuilderWithHeaders(
Stores.timestampedKeyValueStoreWithHeadersBuilder(
Stores.persistentTimestampedKeyValueStoreWithHeaders(STORE_NAME),
Serdes.String(),
Serdes.String()))
Expand Down Expand Up @@ -1622,7 +1622,7 @@ private void shouldMigrateSessionStoreToSessionStoreWithHeaders(final boolean is
final StreamsBuilder newBuilder = new StreamsBuilder();
final AtomicReference<SessionWithHeadersProcessor> processorRef = new AtomicReference<>();
newBuilder.addStateStore(
Stores.sessionStoreBuilderWithHeaders(
Stores.sessionStoreWithHeadersBuilder(
isPersistent ? Stores.persistentSessionStoreWithHeaders(SESSION_STORE_NAME, Duration.ofMillis(RETENTION_MS)) :
Stores.inMemorySessionStore(SESSION_STORE_NAME, Duration.ofMillis(RETENTION_MS)),
Serdes.String(),
Expand Down Expand Up @@ -1680,7 +1680,7 @@ public void shouldProxySessionStoreToSessionStoreWithHeaders() throws Exception
final StreamsBuilder newBuilder = new StreamsBuilder();
final AtomicReference<SessionWithHeadersProcessor> processorRef = new AtomicReference<>();
newBuilder.addStateStore(
Stores.sessionStoreBuilderWithHeaders(
Stores.sessionStoreWithHeadersBuilder(
Stores.persistentSessionStore(SESSION_STORE_NAME, Duration.ofMillis(RETENTION_MS)), // non-headers supplier!
Serdes.String(),
Serdes.String()))
Expand Down Expand Up @@ -1941,7 +1941,7 @@ private void setupAndPopulateSessionStoreWithHeaders(final Properties props) thr
final StreamsBuilder headersBuilder = new StreamsBuilder();
final AtomicReference<SessionWithHeadersProcessor> processorRef = new AtomicReference<>();
headersBuilder.addStateStore(
Stores.sessionStoreBuilderWithHeaders(
Stores.sessionStoreWithHeadersBuilder(
Stores.persistentSessionStoreWithHeaders(SESSION_STORE_NAME, Duration.ofMillis(RETENTION_MS)),
Serdes.String(),
Serdes.String()))
Expand Down
Loading
Loading