fix(tdigest): fix incorrect min/max default initialization#3463
Open
Tangruilin wants to merge 1 commit intoapache:unstablefrom
Open
fix(tdigest): fix incorrect min/max default initialization#3463Tangruilin wants to merge 1 commit intoapache:unstablefrom
Tangruilin wants to merge 1 commit intoapache:unstablefrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes TDigest empty-merge correctness by ensuring CentroidsWithDelta doesn’t default min/max to 0 (which can corrupt subsequent min/max updates), and prevents accidental Reset({}) calls by explicitly deleting the initializer_list overload.
Changes:
- Initialize
CentroidsWithDelta::{delta,min,max,total_weight}with safe defaults usingstd::numeric_limits. - Delete
TDigest::Reset(std::initializer_list<CentroidsWithDelta>)to makeReset({})a compile-time error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/types/tdigest.h | Sets safe default values for CentroidsWithDelta (notably min/max) to avoid incorrect behavior when empty digests are merged/reset. |
| src/types/tdigest.cc | Deletes Reset(std::initializer_list<...>) to prevent accidental braced-init calls selecting the wrong overload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jihuayu
reviewed
Apr 26, 2026
Tangruilin
force-pushed
the
fix#tdigest_reset
branch
from
8fd753c to
71541b1
Compare
jihuayu
reviewed
Apr 26, 2026
CentroidsWithDelta struct was default-initializing min and max to 0,
which caused incorrect behavior when merging empty tdigests. Also
delete Reset({}) overload to prevent accidental misuse.
Assisted-by: Claude Code:glm-5
Tangruilin
force-pushed
the
fix#tdigest_reset
branch
from
71541b1 to
b9a1682
Compare
jihuayu
approved these changes
Apr 26, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CentroidsWithDelta struct was default-initializing min and max to 0, which caused incorrect behavior when merging empty tdigests. Also delete Reset({}) overload to prevent accidental misuse.
Assisted-by: Claude Code:glm-5