fix(replication): reject unsafe fullsync file names#3483
Merged
git-hulk merged 5 commits intoMay 11, 2026
Conversation
Replication fullsync uses file names received from the peer to fetch checkpoint files and materialize them under the local sync checkpoint directory. Previously those names were joined directly with local directories, so traversal components could escape the intended directory during existence checks, temporary file creation, rename, cleanup, or master-side file open. Add a shared replication file-name validator and apply it at the metadata parsing and storage helper boundaries. The validator allows expected relative checkpoint paths such as meta/1, but rejects absolute paths, empty path components, dot segments, trailing slashes, embedded NULs, backslashes, and colon characters. Add cppunit coverage that verifies safe nested names still work and unsafe names are rejected without creating escaped files.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
PragmaTwice
approved these changes
May 11, 2026
nkroker
pushed a commit
to nkroker/kvrocks
that referenced
this pull request
May 29, 2026
Replication fullsync uses the peer's file names to fetch checkpoint files and materialize them in the local sync checkpoint directory. Previously, those names were joined directly with local directories, so traversal components could escape the intended directory during existence checks, temporary file creation, rename, cleanup, or master-side file open. Assisted-by: Codex/GPT 5.5 xhigh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replication fullsync uses the peer's file names to fetch checkpoint files
and materialize them in the local sync checkpoint directory. Previously,
those names were joined directly with local directories,
so traversal components could escape the intended directory during existence checks,
temporary file creation, rename, cleanup, or master-side file open.
Assisted-by: Codex/GPT 5.5 xhigh