refactor(cluster): remove the redis-command migration type#3544
Open
git-hulk wants to merge 1 commit into
Open
refactor(cluster): remove the redis-command migration type#3544git-hulk wants to merge 1 commit into
git-hulk wants to merge 1 commit into
Conversation
git-hulk
force-pushed
the
remove-redis-command-migrate-type
branch
from
77e5125 to
8418840
Compare
This PR removes the `redis-command` slot migration type, leaving raw-key-value as the only migration way. The raw-key-value type has been introduced for a long time, and it outperforms the redis-command type in both resource consumption and migration speed, so we can remove it to simplify the slot migration codes. To be noticed, there is no fallback anymore, the migration now fails with the error `destination node doesn't support the APPLYBATCH command` if the destination node doesn't support the APPLYBATCH command, instead of silently falling back to the redis-command type. Assitanted By Claude Fable 5
git-hulk
force-pushed
the
remove-redis-command-migrate-type
branch
from
8418840 to
401c7e5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
redis-commandslot migration type, leaving raw-key-valueas the only migration path. The raw-key-value type has been introduced for a long time, and it outperforms the redis-command type in both resource consumption and migration speed, so we can remove it to simplify the slot migration code. Also, the redis command migration didn't work well after introducing more and more new data types.
To be noticed, there is no fallback anymore, the migration now fails with the error
destination node doesn't support the APPLYBATCH commandif the destinationnode doesn't support the APPLYBATCH command, instead of silently falling back to the redis-command type.
Assistant By Claude Fable 5