fix(cluster): release forbidden slot range on CLUSTER RESET#3545
Open
git-hulk wants to merge 1 commit into
Open
fix(cluster): release forbidden slot range on CLUSTER RESET#3545git-hulk wants to merge 1 commit into
git-hulk wants to merge 1 commit into
Conversation
After a slot has been migrated away, the source node keeps `forbidden_slot_range_` set. That is normally harmless because the topology no longer routes the slot to this node, so the forbidden-slot check is never reached. But `CLUSTER RESET` clears the topology while leaving the migrator's forbidden range intact — a subsequent SETNODES that reassigns the slot back to this node then spuriously rejects writes with `TRYAGAIN Can't write to slot being migrated`. Explicitly release the forbidden slot range in `Cluster::Reset` to fix this. Assistant-By: Claude Opus 4.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a slot has been migrated away, the source node keeps
forbidden_slot_range_set. That is normally harmless because the topology no longer routes the slot to this node, so the forbidden-slot check is never reached. ButCLUSTER RESETclears the topology while leaving the migrator's forbidden range intact — a subsequent SETNODES that reassigns the slot back to this node then spuriously rejects writes withTRYAGAIN Can't write to slot being migrated. Explicitly release the forbidden slot range inCluster::Resetto fix this.Assistant-By: Claude Opus 4.7