Skip to content

[KYUUBI #6815] fix jdbc oracle engine NUMBER(20,0) type problem #7463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ylq5126 wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −3
Open

[KYUUBI #6815] fix jdbc oracle engine NUMBER(20,0) type problem #7463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80ef62e
fix jdbc oracle engine NUMBER(20,0) type problem
ylq5126 May 21, 2026
588c3fe
fix jdbc oracle engine NUMBER(20,0) type problem
ylq5126 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/oracle/OracleSchemaHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class OracleSchemaHelper extends SchemaHelper {
override protected def toTTypeDesc(sqlType: Int, precision: Int, scale: Int): TTypeDesc = {
sqlType match {
// case for int, returns NUMERIC type in Oracle JDBC
case Types.NUMERIC if scale == 0 =>
case Types.NUMERIC if scale == 0 && (precision > 0 && precision <= 9) =>
super.toTTypeDesc(Types.INTEGER, precision, scale)
// except for int
case Types.NUMERIC =>
Expand Down
5 changes: 3 additions & 2 deletions ...c-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/oracle/OracleTRowSetGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ class OracleTRowSetGenerator extends DefaultJdbcTRowSetGenerator {
}

override def getColumnType(schema: Seq[Column], ordinal: Int): Int = {
schema(ordinal).sqlType match {
val col = schema(ordinal)
col.sqlType match {
// case for int, returns NUMERIC type in Oracle JDBC
case Types.NUMERIC if schema(ordinal).scale == 0 =>
case Types.NUMERIC if col.scale == 0 && (col.precision > 0 && col.precision <= 9) =>
Types.INTEGER
case Types.NUMERIC =>
Types.DECIMAL
Expand Down
Loading