LOG4J2-2073: Fix NPE in ConfigurationScheduler when scheduling cron tasks

[bhawnapannu2701]

Problem
ConfigurationScheduler.scheduleWithCron created a CronRunnable, scheduled it, and only afterwards assigned its CronScheduledFuture.
Under fast-firing cron expressions the runnable could execute before its future was set, causing a NullPointerException when calling scheduledFuture.getFireTime().

Root cause
Race condition between scheduling the task and assigning the CronScheduledFuture to the runnable.

Fix

Assign a placeholder CronScheduledFuture to the runnable before scheduling.

Update that placeholder with the real ScheduledFuture immediately after scheduling.

Add null-guards in CronRunnable.run() and handle first execution safely.

Enhance toString() to tolerate an unassigned future.

Tests
Added CronSchedulerNpeTest which schedules a cron expression firing every second and asserts that it runs without throwing.
Before the fix it reproduced the NPE; after the fix all tests pass.

Risks
Minimal. Changes are contained to cron scheduling logic and do not alter normal scheduling semantics.

[vy]

@bhawnapannu2701, thanks so much for the PR. Please see the remarks I've shared.

I strongly advice you to read the Development guide. This will make life easier for both of us.

[vy]

Would you implement the following changes, please?

1. This test is not effective. That is, it even passes without the fix. Could you make sure this test fails without the fix?
2. Could you move this test from log4j-core/src/test to log4j-core-test/src/test?
3. Could you add the license header?
4. Could you make sure ./mvnw verify -pl :log4j-core,:log4j-core-test passes before submitting your changes?

[vy]

1. Remove the FIX (part 1)-sort comments, please. Instead, if something is not obvious at first glance, explain in the rationale, when necessary.
2. Run linter: ./mvnw spotless:apply -pl :log4j-core
3. Don't touch/change unrelated lines

[AnvitAjgaokar]

Hi @vy,

I noticed that this PR is still open and has some review comments pending.
I’d like to ask if it would be okay for me to work on addressing the requested changes
(for LOG4J2-2073: Fix NPE in ConfigurationScheduler when scheduling cron tasks).

If this is still active, I’d be happy to help move it forward and submit an update.
Please let me know if that would be helpful, or if someone is already working on it.

Thanks for your time and for maintaining the project.

[vy]

@AnvitAjgaokar, you don't need a permission. Just submit your PR.

[vy]

@ramanathan1504, this is very close to the finish line. Would you like to pick this one up?

[ramanathan1504]

@vy, Yes, I can take this one. I’ll review what’s left and push it to completion.

[vy]

Superseded by #4118.