Remove the patternFlags attribute from RegexFilter#4119
Merged
Conversation
+ made AbstractFiltter.AbstractFilterBuilder onMatch/onMismatch fields protected + added AbstractFilter(AbstractFilterBuilder) constructor + added RegexFilter.Builder implementation + added RegexFilter(Builder) constructor + moved RegexFilter Pattern compile into constructor + added fields to persist configuration propertties + getters (regexExpression, patternFlags) + changed private constructor to accept builder as argument + renamed private method 'targetMessageTest' to more approprriate 'getMessageTextByType' + added Javadoc + grouped deprecations
+ added validation checks to RegexFilter + added JVerify nullability annotations to RegexFilter + updated javadoc + replaced deprecated usages of CompositeFilter#getFilters with CompositeFilter#getFiltersArray in AbstractFilterableTest
…gex patternFlags via a CSV attribute, and improve handling of useRawMsg with a primitive boolean.
vy
reviewed
May 28, 2026
vy
changed the title
patternFlags attribute from RegexFilter
vy
approved these changes
Jun 11, 2026
github-project-automation
Bot
moved this from Approved
to Merged
in Log4j pull request tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3086
This pull request refactors the
RegexFilterto use a plugin builder pattern, restores support for configuring regexpatternFlagsvia a comma-separated attribute, and improves robustness around theuseRawMsgoption. It also adds tests and documentation for the new pattern flags feature.RegexFilter Refactor and Feature Restoration:
RegexFilterto use a plugin builder (Builderclass), simplifying construction and improving maintainability. The builder now uses a primitive boolean foruseRawMsgto avoid null-unboxing issues. [1] [2]patternFlagsvia a comma-separated string attribute (e.g.,patternFlags="CASE_INSENSITIVE"), replacing the previous, more cumbersome approach.Testing Improvements:
testPatternFlagsFromConfiguration) inRegexFilterTest.javato verify that pattern flags are correctly loaded from configuration files.RegexFilterPatternFlagsTest.xmlto exercise the new pattern flags feature.Documentation and Changelog:
patternFlagsattribute, listing all supported flag values and usage.patternFlags, and the builder improvements.Other:
2.26.0to reflect the new feature.