deps(java): bump com.google.errorprone:error_prone_core from 2.49.0 to 2.50.0 (#16291)

* deps(java): bump com.google.errorprone:error_prone_core

Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.49.0 to 2.50.0.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.49.0...v2.50.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-version: 2.50.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update lock file, add canonical name for JavaLangClash

* Add new errorprone checks and fix violations.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>

Author: dependabot[bot]

build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/ErrorPronePlugin.java

@@ -298,6 +298,7 @@ public void apply(Project project) {
     "AutoValueFinalMethods:OFF", // we don't use autovalue
     "AutoValueImmutableFields:OFF", // we don't use autovalue
     "AutoValueSubclassLeaked:OFF", // we don't use autovalue
+    "AvoidCommonTypeNames:OFF", // TODO: there are problems
     "AvoidObjectArrays:OFF", // TODO: new, not checked if applicable to Lucene
     "AvoidValueSetter:ERROR",
     "BadAnnotationImplementation:ERROR",
@@ -317,6 +318,7 @@ public void apply(Project project) {
     "BooleanParameter:OFF", // TODO: new, not checked if applicable to Lucene
     "BoxedPrimitiveConstructor:OFF", // we have forbiddenapis for that
     "BoxedPrimitiveEquality:OFF", // TODO: there are problems
+    "BoxingComparator:ERROR",
     "BugPatternNaming:OFF", // we don't use this annotation
     "BuilderReturnThis:OFF", // TODO: new, not checked if applicable to Lucene
     "BundleDeserializationCast:OFF", // we don't use android
@@ -417,6 +419,7 @@ public void apply(Project project) {
     "ExpectedExceptionChecker:OFF", // TODO: new, not checked if applicable to Lucene
     "ExpensiveLenientFormatString:OFF", // we use astgrep for this check.
     "ExplicitArrayForVarargs:OFF", // TODO: new, not checked if applicable to Lucene
+    "ExposedPrivateType:OFF", // TODO: there are multiple violations
     "ExtendingJUnitAssert:OFF", // noisy
     "ExtendsAutoValue:OFF", // TODO: new, not checked if applicable to Lucene
     "ExtendsObject:OFF", // TODO: there are problems
@@ -547,14 +550,14 @@ public void apply(Project project) {
     "JUnitAmbiguousTestClass:OFF", // we don't use junit3
     "JUnitAssertSameCheck:ERROR",
     "JUnitIncompatibleType:WARN",
+    "JUnitMethodInvoked:OFF", // irrelevant
     "JUnitParameterMethodNotFound:ERROR",
     "Java8ApiChecker:OFF", // TODO: new, not checked if applicable to Lucene
     "JavaDurationGetSecondsGetNano:OFF", // we don't use these Duration methods
     "JavaDurationGetSecondsToToSeconds:OFF", // we don't use these Duration methods
     "JavaDurationWithNanos:OFF", // we don't use these Duration methods
     "JavaDurationWithSeconds:OFF", // we don't use these Duration methods
     "JavaInstantGetSecondsGetNano:OFF", // we don't use these Instant methods
-    "JavaLangClash:OFF", // TODO: there are problems
     "JavaLocalDateTimeGetNano:OFF", // we don't use LocalDateTime
     "JavaLocalTimeGetNano:OFF", // we don't use LocalTime
     "JavaPeriodGetDays:OFF", // we don't use Period
@@ -575,6 +578,7 @@ public void apply(Project project) {
     "LabelledBreakTarget:OFF", // stylistic
     "LambdaFunctionalInterface:OFF", // TODO: new, not checked if applicable to Lucene
     "LenientFormatStringValidation:OFF", // we don't use these google libraries
+    "ListRemoveAmbiguous:OFF", // true potential bug but tiny probability
     "LiteByteStringUtf8:OFF", // we don't use protobuf
     "LiteEnumValueOf:OFF", // we don't use protobuf
     "LiteProtoToString:OFF", // we don't use protobuf
@@ -699,6 +703,7 @@ public void apply(Project project) {
     "PreconditionsInvalidPlaceholder:OFF", // we don't use guava
     "PreferInstanceofOverGetKind:OFF", // TODO: new, not checked if applicable to Lucene
     "PreferJavaTimeOverload:OFF", // TODO: new, not checked if applicable to Lucene
+    "PreferTestParameter:OFF", // irrelevant
     "PreferThrowsTag:OFF", // TODO: perhaps worth considering
     "PreferredInterfaceType:OFF", // TODO: new, not checked if applicable to Lucene
     "PrimitiveArrayPassedToVarargsMethod:OFF", // TODO: new, not checked if applicable to Lucene
@@ -721,6 +726,8 @@ public void apply(Project project) {
     "RandomModInteger:ERROR",
     "ReachabilityFenceUsage:WARN",
     "RecordAccessorInCompactConstructor:ERROR",
+    "RecordComponentAccessorAnnotationConflict:OFF", // not applicable in Lucene
+    "RecordComponentOverride:OFF", // not applicable in Lucene
     "RectIntersectReturnValueIgnored:OFF", // we don't use android
     "RedundantControlFlow:OFF", // stylistic
     "RedundantNullCheck:ERROR",
@@ -799,6 +806,7 @@ public void apply(Project project) {
     "ThrowIfUncheckedKnownUnchecked:OFF", // we don't use these google libraries
     "ThrowNull:OFF", // noisy (LuceneTestCase)
     "ThrowSpecificExceptions:OFF", // TODO: new, not checked if applicable to Lucene
+    "ThrowableEqualsHashCode:ERROR",
     "ThrowsUncheckedException:OFF", // TODO: new, not checked if applicable to Lucene
     "TimeInStaticInitializer:ERROR",
     "TimeUnitConversionChecker:WARN",
@@ -878,6 +886,7 @@ public void apply(Project project) {
     "UsingJsr305CheckReturnValue:OFF", // TODO: new, not checked if applicable to Lucene
     "Var:OFF", // TODO: new, not checked if applicable to Lucene
     "VarTypeName:ERROR",
+    "VarWithPrimitive:OFF", // very subjective
     "VariableNameSameAsType:WARN",
     "Varifier:OFF", // TODO: new, not checked if applicable to Lucene
     "VoidMissingNullable:OFF", // TODO: new, not checked if applicable to Lucene

gradle/libs.versions.toml

@@ -11,7 +11,7 @@ commons-compress = "1.28.0"
 # See ecj-lint.gradle (used for more linting).
 ecj = "3.44.0"
 # java linting
-errorprone = "2.49.0"
+errorprone = "2.50.0"
 # markdown documentation generation
 flexmark = "0.64.8"
 # @keep This is GJF version for java source code formatting

lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordFormGenerator.java

@@ -450,7 +450,7 @@ void registerStem(String stem) {
     EntrySuggestion compress() {
       Comparator<String> stemSorter =
           Comparator.comparing((String s) -> existingStems.contains(s))
-              .thenComparing(s -> stemsToForms.get(s).size())
+              .thenComparingInt(s -> stemsToForms.get(s).size())
               .reversed();
       List<String> sortedStems = stemsToForms.keySet().stream().sorted(stemSorter).toList();
       PriorityQueue<State> queue = new PriorityQueue<>(solutionFitness);

lucene/analysis/common/src/tools/java/org/apache/lucene/analysis/standard/GenerateJflexTLDMacros.java

@@ -119,7 +119,7 @@ public static void main(String... args) throws Exception {
 
   private final SortedMap<String, Boolean> processedTLDsLongestFirst =
       new TreeMap<>(
-          Comparator.comparing(String::length).reversed().thenComparing(String::compareTo));
+          Comparator.comparingInt(String::length).reversed().thenComparing(String::compareTo));
 
   // list position indicates suffix length
   private final List<SortedSet<String>> TLDsBySuffixLength = new ArrayList<>();

lucene/core/src/java/org/apache/lucene/search/DisjunctionScoreBlockBoundaryPropagator.java

@@ -40,7 +40,7 @@ final class DisjunctionScoreBlockBoundaryPropagator {
                   throw new RuntimeException(e);
                 }
               })
-          .thenComparing(s -> s.iterator().cost());
+          .thenComparingLong(s -> s.iterator().cost());
 
   private final Scorer[] scorers;
   private final float[] maxScores;

lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java

@@ -1374,7 +1374,7 @@ public int hashCode() {
               ddq,
               new SimpleCollectorManager(
                   numDocs,
-                  Comparator.comparing(cr -> cr.docAndScore.doc),
+                  Comparator.comparingInt(cr -> cr.docAndScore.doc),
                   ScoreMode.COMPLETE_NO_SCORES));
 
       Sort sort = new Sort(new SortField("id", SortField.Type.STRING));

lucene/luke/src/java/org/apache/lucene/luke/app/desktop/util/TableUtils.java

@@ -83,7 +83,8 @@ public static <T extends TableColumnInfo> String[] columnNames(T[] columns) {
   public static <T extends TableColumnInfo> TreeMap<Integer, T> columnMap(T[] columns) {
     return Arrays.stream(columns)
         .collect(
-            Collectors.toMap(T::getIndex, UnaryOperator.identity(), (e1, _) -> e1, TreeMap::new));
+            Collectors.toMap(
+                TableColumnInfo::getIndex, UnaryOperator.identity(), (e1, _) -> e1, TreeMap::new));
   }
 
   private TableUtils() {}

lucene/queries/src/java/org/apache/lucene/queries/spans/SpanWeight.java

@@ -330,7 +330,7 @@ public Query getQuery() {
             void collectInnerTerms() throws IOException {
               termCollector.reset();
               spans.collect(termCollector);
-              Arrays.sort(innerTerms, 0, innerTermCount, Comparator.comparing(a -> a.position));
+              Arrays.sort(innerTerms, 0, innerTermCount, Comparator.comparingInt(a -> a.position));
             }
           };
         });

lucene/sandbox/src/java/org/apache/lucene/sandbox/search/LargeNumHitsTopDocsCollector.java

@@ -21,7 +21,6 @@
 
 import java.io.IOException;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
 import org.apache.lucene.index.LeafReaderContext;
@@ -146,11 +145,10 @@ protected void populateResults(ScoreDoc[] results, int howMany) {
 
     // Total number of hits collected were less than requestedHitCount
     assert totalHits <= requestedHitCount;
-    Collections.sort(
-        hits,
-        Comparator.comparing((ScoreDoc scoreDoc) -> scoreDoc.score)
+    hits.sort(
+        Comparator.comparingDouble((ScoreDoc scoreDoc) -> scoreDoc.score)
             .reversed()
-            .thenComparing(scoreDoc -> scoreDoc.doc));
+            .thenComparingInt(scoreDoc -> scoreDoc.doc));
 
     for (int i = 0; i < howMany; i++) {
       results[i] = hits.get(i);

lucene/sandbox/src/java/org/apache/lucene/sandbox/search/SortedNumericDocValuesMultiRangeQuery.java

@@ -89,7 +89,7 @@ private static NavigableSet<DocValuesMultiRangeQuery.LongRange> resolveOverlaps(
       Collection<DocValuesMultiRangeQuery.LongRange> clauses) {
     NavigableSet<DocValuesMultiRangeQuery.LongRange> sortedClauses =
         new TreeSet<>(
-            Comparator.comparing(r -> r.lower)
+            Comparator.comparingLong(r -> r.lower)
             // .thenComparing(r -> r.upper)// have to ignore upper boundary for .floor() lookups
             );
     List<Edge> clauseEdges = new ArrayList<>(clauses.size() * 2);