Add test coverage for GCD transform edge cases

- Variable cardinality: exercises the per-doc fallback
  loop when denseFixedCardinality == -1
- Between-multiples bounds: exercises transformGcdBounds
  null early-exit when query range falls between GCD
  multiples
- Randomized test: add variable cardinality and
  between-multiples variations

Author: costin

lucene/core/src/test/org/apache/lucene/search/TestSkipBlockRangeIteratorIntoBitSet.java

@@ -897,6 +897,97 @@ public void testSortedNumericGcdNegativeValuesRangeIntoBitSet() throws Exception
     doTestSortedNumericGcdRangeIntoBitSet(true, 3, 7, -1_000_000_000L);
   }
 
+  /**
+   * Tests rangeIntoBitSet on GCD-encoded sorted numeric with variable cardinality. Exercises the
+   * per-doc fallback loop (rawValues != null, denseFixedCardinality == -1) rather than the
+   * fixed-cardinality scalar fast path.
+   */
+  public void testSortedNumericGcdVariableCardinalityRangeIntoBitSet() throws Exception {
+    int numDocs = 4096 * 2;
+    long gcd = 100;
+    long offset = 500_000L;
+    try (Directory dir = newDirectory()) {
+      IndexWriterConfig iwc = new IndexWriterConfig().setCodec(new Lucene104Codec());
+      try (IndexWriter w = new IndexWriter(dir, iwc)) {
+        for (int docID = 0; docID < numDocs; docID++) {
+          Document doc = new Document();
+          long base = ((docID * 13L) % 100) * gcd + offset;
+          int cardinality = (docID % 3) + 1;
+          for (int i = 0; i < cardinality; i++) {
+            doc.add(SortedNumericDocValuesField.indexedField("sn", base + i * gcd));
+          }
+          w.addDocument(doc);
+        }
+        w.forceMerge(1);
+      }
+
+      try (DirectoryReader reader = DirectoryReader.open(dir)) {
+        LeafReaderContext ctx = reader.leaves().get(0);
+        long queryMin = 20 * gcd + offset;
+        long queryMax = 40 * gcd + offset;
+
+        FixedBitSet expected = new FixedBitSet(numDocs);
+        var expectedValues = ctx.reader().getSortedNumericDocValues("sn");
+        for (int docID = 0; docID < numDocs; docID++) {
+          if (expectedValues.advanceExact(docID)) {
+            for (int i = 0, count = expectedValues.docValueCount(); i < count; i++) {
+              long value = expectedValues.nextValue();
+              if (value >= queryMin) {
+                if (value <= queryMax) {
+                  expected.set(docID);
+                }
+                break;
+              }
+            }
+          }
+        }
+
+        FixedBitSet actual = new FixedBitSet(numDocs);
+        ctx.reader()
+            .getSortedNumericDocValues("sn")
+            .rangeIntoBitSet(0, numDocs, queryMin, queryMax, actual, 0);
+        assertEquals("GCD sorted numeric variable cardinality", expected, actual);
+      }
+    }
+  }
+
+  /**
+   * Tests that rangeIntoBitSet correctly handles query bounds that fall between GCD multiples,
+   * exercising the {@code transformGcdBounds} null early-exit (no raw value can match).
+   */
+  public void testSortedNumericGcdBoundsBetweenMultiplesRangeIntoBitSet() throws Exception {
+    int numDocs = 4096 * 2;
+    long gcd = 1000;
+    long offset = 500_000L;
+    try (Directory dir = newDirectory()) {
+      IndexWriterConfig iwc = new IndexWriterConfig().setCodec(new Lucene104Codec());
+      try (IndexWriter w = new IndexWriter(dir, iwc)) {
+        for (int docID = 0; docID < numDocs; docID++) {
+          Document doc = new Document();
+          long base = ((docID * 13L) % 100) * gcd + offset;
+          for (int i = 0; i < 3; i++) {
+            doc.add(SortedNumericDocValuesField.indexedField("sn", base + i * gcd));
+          }
+          w.addDocument(doc);
+        }
+        w.forceMerge(1);
+      }
+
+      try (DirectoryReader reader = DirectoryReader.open(dir)) {
+        LeafReaderContext ctx = reader.leaves().get(0);
+        long queryMin = 20 * gcd + offset + 1;
+        long queryMax = 21 * gcd + offset - 1;
+
+        FixedBitSet actual = new FixedBitSet(numDocs);
+        ctx.reader()
+            .getSortedNumericDocValues("sn")
+            .rangeIntoBitSet(0, numDocs, queryMin, queryMax, actual, 0);
+        assertEquals(
+            "GCD bounds between multiples should match zero docs", 0, actual.cardinality());
+      }
+    }
+  }
+
   private void doTestSortedNumericGcdRangeIntoBitSet(
       boolean dense, int cardinality, long gcd, long offset) throws Exception {
     int numDocs = 4096 * 2;
@@ -961,6 +1052,7 @@ public void testSortedNumericGcdRangeIntoBitSetRandomized() throws Exception {
     Random rng = random();
     for (int iter = 0; iter < 10; iter++) {
       boolean dense = rng.nextBoolean();
+      boolean variableCardinality = rng.nextBoolean();
       int cardinality = rng.nextInt(1, 6);
       long gcd = rng.nextLong(2, 1000);
       long offset = rng.nextLong(0, 1_000_000_000L);
@@ -973,7 +1065,8 @@ public void testSortedNumericGcdRangeIntoBitSetRandomized() throws Exception {
             Document doc = new Document();
             if (dense || docID % 3 != 0) {
               long base = rng.nextLong(0, 100) * gcd + offset;
-              for (int i = 0; i < cardinality; i++) {
+              int docCardinality = variableCardinality ? rng.nextInt(1, 6) : cardinality;
+              for (int i = 0; i < docCardinality; i++) {
                 doc.add(SortedNumericDocValuesField.indexedField("sn", base + i * gcd));
               }
             }
@@ -986,6 +1079,10 @@ public void testSortedNumericGcdRangeIntoBitSetRandomized() throws Exception {
           LeafReaderContext ctx = reader.leaves().get(0);
           long queryMin = rng.nextLong(0, 50) * gcd + offset;
           long queryMax = rng.nextLong(50, 100) * gcd + offset;
+          if (rng.nextBoolean()) {
+            queryMin += rng.nextLong(1, gcd);
+            queryMax -= rng.nextLong(1, gcd);
+          }
 
           FixedBitSet expected = new FixedBitSet(numDocs);
           var expectedValues = ctx.reader().getSortedNumericDocValues("sn");