Remove all deprecated IndexSearcher#search(Query, Collector) usage / methods in the next major release

[zacharymorn]

Description

As a follow-up of #11041, we would like to remove all deprecated IndexSearcher#search(Query, Collector) methods in the next major release, preferably 10.0.0.

A list of the leftover usages follows:

• facet: FacetsCollector (ongoing discussion at Should the static search methods in FacetsCollector take a FacetsCollector as last argument? #13725, PR at Replace static FacetsCollector#search methods #13733)
• facet.test: TestTaxonomyFacetAssociations (PR at Remove leftover search(Query, Collector) usages in TestTaxonomyFacetAssociations #13726)
• grouping: GroupingSearch (Introduce BlockGroupingCollectorManager #15936 , Introduce CachingCollectorManager to parallelize search when using CachingCollector #16247)
• grouping.test: BaseGroupSelectorTestCase
• grouping.test: TestAllGroupHeadsCollector (Introduce AllGroupHeadsCollectorManager #15565)
• grouping.test: TestAllGroupsCollector (Introduce AllGroupsCollectorManager #15557)
• grouping.test: TestDistinctValuesCollector (Add DistinctValuesCollectorManager to enable concurrent search #16217)
• grouping.test: TestGroupFacetCollector (Introduce TermGroupFacetCollectorManager for concurrent grouped faceting #16292)
• grouping.test: TestGrouping (Introduce CachingCollectorManager to parallelize search when using CachingCollector #16247, Replace deprecated search(Query, Collector) with search(Query, CollectorManager) in TestGrouping #16379)
• join: JoinUtil (PR at Remove usage of IndexSearcher#search(Query, Collector) from join package #13747, Replace deprecated search(Query, Collector) with CollectorManager in JoinUtil #16091)
• join.test: TestJoinUtil (Replace search(Query, Collector) deprecated usages in TestJoinUtil  #16262)
• monitor: CollectingMatcher (PR at Remove usage of IndexSearcher#Search(Query, Collector) from monitor package #13735)
• monitor remaining usages (Remove deprecated usages of search(Query, Collector) from monitor module #16197)
• test-framework: QueryUtils (Replace SimpleCollector driver with explicit leaf iteration in QueryUtils #16266)
• misc.test: TestDiversifiedTopDocsCollector (Add DiversifiedTopDocsCollectorManager to enable concurrent search #16216)
• misc.test: TestDocValuesStatsCollector
• misc.test: TestMemoryAccountingBitsetCollector
• sandbox.test: TestLargeNumHitsTopDocsCollector
• sandbox.test: TestProfilerCollector (PR at Introduce ProfilerCollectorManager #13746)

[javanna]

I have been looking into this, there are unfortunately ~85 leftover usages of this method. Would be great to clean this up for Lucene 10. I opened a few small PRs around this.

I think though that FacetsCollector needs extensive rework to leverage collector managers instead of collectors. I think it would be much simpler if the static search methods that FacetsCollector exposes took a FacetsCollector as last argument instead of a generic Collector. That seems to cover all of our internal usages, but I am not sure what the expectations are around users usage for such methods. We should discuss how we want to revisit the facets API as a whole.

[javanna]

I edited the description of this issue to include an extensive list of the leftover usages that need fixing.