Modernize and move error prone gradle plugin to Java#15305
Merged
Conversation
…inst actual ErrorProne version so that we keep the code synced on updates.
dweiss
added
skip-changelog
dweiss
commented
Oct 8, 2025
Comment on lines
+136
to
+138
| BuiltInCheckerSuppliers.ENABLED_ERRORS, | ||
| BuiltInCheckerSuppliers.ENABLED_WARNINGS, | ||
| BuiltInCheckerSuppliers.DISABLED_CHECKS) |
Contributor
Author
There was a problem hiding this comment.
I added all checks - even those disabled by default in error-prone. Those that were missing are turned off in the list below too.
dweiss
added a commit
that referenced
this pull request
Oct 9, 2025
…led checks. Follow-up to #15305.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is yet another round of the same but this one is more complex. I've rewritten the plugin for error prone so that it always cross-checks the list of checks we have declared in the plugin against the imported error-prone version. So when you upgrade, it'll fail if something is removed or added.