Speed up slow tests (#15212)#15306
Conversation
…st java's priority queue. Same net result.
| // Lucene's PriorityQueue.remove uses reference equality, not .equals to determine which | ||
| // elements | ||
| // to remove (!). | ||
| HashMap<Integer, Integer> ints = new HashMap<>(); |
There was a problem hiding this comment.
This test had a huge iteration count, was checking tons of stuff unnecessarily... I rewrote it to just compare against Java's PriorityQueue... but it turned out that lucene's PriorityQueue.remove(T) is implemented as a linear scan through all elements, with reference equality (which is surprising to say the least...). That's why this "cache" of ints needs to be here.
PQ.remove is only used from one place within Lucene... maybe we should drop this method entirely (or at least change == to .equals to be less surprising?).
There was a problem hiding this comment.
+1 to open a followup issue on this!
|
I'll help with merging this branch out of conflicts: I'm not actually "fixing" anything in |
|
No worries, I'll handle the merge and conflicts. |
github-actions
Bot
added
module:core/search
module:build-infra
and removed
module:core/other
labels
|
I'll merge this in. There's been work on speeding up tests on other branches and indeed - we can just tackle them individually, on need for this branch. |
2 participants
No description provided.