fix(apache#15309): Optimize PriorityQueue.remove() function

[vijaykriishna]

Description

[dweiss]

PQs are so heavily used in Lucene that any extra cost added to add() will be probably a no-no. Can you run the benchmarks and see how it affects performance?

[benwtrent]

I don't think any code actually uses remove...I don't think making it faster is worth making anything else more expensive.

[vijaykriishna]

@dweiss @benwtrent Are you suggesting to get rid of remove function once and for all ?

[vijaykriishna]

PriorityQueue.remove function is used by DiversifiedTopDocsCollector. Ref.

lucene/lucene/misc/src/java/org/apache/lucene/misc/search/DiversifiedTopDocsCollector.java

Line 154 in 71e822e

globalQueue.remove(perKeyOverflow);

.

Hence, felt to not remove it altogether.

[benwtrent]

@vijaykriishna I would much prefer the single use gets optimized than adding cost to the priority queue to everything.

[dweiss]

Yes, I think we should remove it. It's only used in one place and this place could probably do away with something else instead.

[dweiss]

@vijaykriishna if you'd like to continue - feel free to review DiversifiedTopDocsCollector to see if it can be implemented in a different way, then nuke that remove method from the PriorityQueue class! I'll be away this week but it'd be great to push this forward.

[dweiss]

Superseded by #15493