Defer Sorter.DocMap packing until after flush#16048
Open
Tim-Brooks wants to merge 2 commits into
Open
Conversation
IndexingChain calls sortMap.oldToNew heavily during flush — per posting in FreqProxTermsWriter, per (field, doc) in DV writers, per vector in KNN writers. The previous implementation built oldToNew as a PackedLongValues, which is slow for that random-access hot path. Build oldToNew as an int[] during flush, then pack to PackedLongValues before storing on FlushedSegment, which is retained long-term on ReadersAndUpdates for sorted segments with seg-private updates.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

IndexingChain calls sortMap.oldToNew heavily during flush — per posting
in FreqProxTermsWriter, per (field, doc) in DV writers, per vector in
KNN writers. The previous implementation built oldToNew as a
PackedLongValues, which is slow for that random-access hot path.
Build oldToNew as an int[] during flush, then pack to PackedLongValues
before storing on FlushedSegment, which is retained long-term on
ReadersAndUpdates for sorted segments with seg-private updates.