You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
extends the unified two-phase strategy from #16177 to SortedDocValues. Ordinal range queries now bulk-evaluate through intoBitSet instead of confirming matches() one doc at a time.
I wonder if this is the right tradeoff for ANN-backed indices in general. Losing the ANN structure for the whole segment after a small vector update and falling back to exact search until merge feels fairly expensive and potentially surprising.
Maybe this only really makes sense for flat indices where there is no ANN structure to invalidate?
The use case that feels more important to me is actually the opposite one: updating other fields/doc values without having to rewrite vectors or rebuild the ANN structure.
I saw the “change of model” use case mentioned in the PR, but in that situation you typically need to reindex everything anyway, so I’m not sure this optimization helps much there.
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extends the unified two-phase strategy from #16177 to SortedDocValues. Ordinal range queries now bulk-evaluate through intoBitSet instead of confirming matches() one doc at a time.