used WANDScorer.advanceShallow() to enable block-max optimizations when nested in conjunctions#16220
Open
iprithv wants to merge 2 commits into
Open
used WANDScorer.advanceShallow() to enable block-max optimizations when nested in conjunctions#16220iprithv wants to merge 2 commits into
iprithv wants to merge 2 commits into
Conversation
costin
approved these changes
Jun 22, 2026
| for (Scorer scorer : allScorers) { | ||
| if (scorer.docID() < target) { | ||
| scorer.advanceShallow(target); | ||
| if (scorer.docID() <= target) { |
Contributor
There was a problem hiding this comment.
Nit: the old code used < target (skip propagation when already at target), this uses <= target. The <= is correct here since you need the return value from advanceShallow even when docID() == target, but worth a one-line comment explaining the change from < to <= (vs a typo).
| if (scorer.docID() <= target) { | ||
| newUpTo = Math.min(newUpTo, scorer.advanceShallow(target)); | ||
| } else if (scorer.docID() != DocIdSetIterator.NO_MORE_DOCS) { | ||
| newUpTo = Math.min(newUpTo, scorer.docID() - 1); |
Contributor
There was a problem hiding this comment.
Consider return (target <= upTo) ? Math.min(upTo, newUpTo) : newUpTo;
Otherwise the early return discards the freshly computed newUpTo, which could be tighter than upTo.
Always returning the previous upTo is safe (advanceShallow contract allows over-approximation), but it means the parent gets a looser bound than necessary hence the suggested conditional.
iprithv
force-pushed
the
wandscorer-advanceshallow
branch
from
d494ad6 to
a09f3be
Compare
github-actions
Bot
added
module:core/store
module:analysis
module:core/index
module:demo
module:highlighter
module:benchmark
module:suggest
module:spatial
module:luke
module:core/codecs
module:facet
module:grouping
module:core/FSTs
module:queryparser
module:join
module:classification
module:test-framework
module:replicator
module:expressions
module:sandbox
module:spatial3d
module:misc
module:queries
module:monitor
labels
github-actions
Bot
removed
module:core/index
module:demo
module:highlighter
module:benchmark
module:suggest
module:spatial
module:luke
module:core/codecs
module:facet
module:grouping
module:core/FSTs
module:queryparser
module:join
module:classification
module:test-framework
module:replicator
module:expressions
module:sandbox
module:spatial3d
module:misc
module:queries
module:monitor
module:core/hnsw
module:build-infra
labels
iprithv
force-pushed
the
wandscorer-advanceshallow
branch
from
d494ad6 to
d245ee3
Compare
…ns when nested in conjunctions
iprithv
force-pushed
the
wandscorer-advanceshallow
branch
from
d245ee3 to
fc65e6e
Compare
iprithv
force-pushed
the
wandscorer-advanceshallow
branch
from
fc65e6e to
3175d3f
Compare
Contributor
Author
|
moved entry of changes.txt under 10.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used WANDScorer.advanceShallow() so that WAND queries nested inside conjunctions can skip blocks instead of treating the entire segment as one giant block.