Fix flaky test TestIndexOptions > testMultiValueForcesDeoptimization#16315
Merged
Conversation
Contributor
|
Thank you for fixing those test failures! I'll wait for builds to pass and merge. |
dweiss
added a commit
that referenced
this pull request
Jul 1, 2026
…16315) * Fix flaky test TestIndexOptions > testMultiValueForcesDeoptimization * Update CHANGES.txt --------- Co-authored-by: Xu Zhang <zhangxuv@amazon.com> Co-authored-by: Dawid Weiss <dawid.weiss@carrotsearch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #16309.
The test assumes a single segment but
newIndexWriterConfig()can randomize maxBufferedDocs to a small value (2-15), the test creates 4 docs, with specific seed, it causes flush that creates multiple segments. Fix by callingforceMerge(1)before opening the reader.Verified the fix by running below command which has the failing seed:
./gradlew :lucene:core:test --tests "org.apache.lucene.index.TestIndexOptions.testMultiValueForcesDeoptimization" -Ptests.asserts=true -Ptests.file.encoding=UTF-8 -Ptests.gui=true -Ptests.jvmargs= -Ptests.jvms=4 -Ptests.seed=9D72F1A3BE205450 -Ptests.vectorsize=256