Skip to content

Lazily allocate DocAndScoreAccBuffer in MaxScoreBulkScorer #16316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romseygeek merged 2 commits into from
Jul 1, 2026
Merged

Lazily allocate DocAndScoreAccBuffer in MaxScoreBulkScorer #16316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e145ec0
Lazily allocate DocAndScoreAccBuffer in MaxScoreBulkScorer
romseygeek Jul 1, 2026
67a1496
changes
romseygeek Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,9 @@ Optimizations
* GITHUB#16146: Speed up no-score filtered-optional Boolean queries by routing dense conjunctions with cached FixedBitSet filters
through ConstantScoreBulkScorer, which batches matches in bulk via DocIdStream. (Costin Leau)

* GITHUB#16316: Lazily allocate buffers in MaxScoreBulkScorer. These are now only allocated when going
via code paths that actually use them. (Alan Woodward)

Bug Fixes
---------------------
(No changes)
Expand Down
5 changes: 2 additions & 3 deletions lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ final class MaxScoreBulkScorer extends BulkScorer {
private FixedBitSet filterMatches = null;

private final DocAndFloatFeatureBuffer docAndScoreBuffer = new DocAndFloatFeatureBuffer();
private final DocAndScoreAccBuffer docAndScoreAccBuffer;
private final DocAndScoreAccBuffer docAndScoreAccBuffer = new DocAndScoreAccBuffer();

MaxScoreBulkScorer(int maxDoc, List<Scorer> scorers, Scorer filter) throws IOException {
this.maxDoc = maxDoc;
Expand All @@ -69,8 +69,6 @@ final class MaxScoreBulkScorer extends BulkScorer {
this.cost = cost;
essentialQueue = DisiPriorityQueue.ofMaxSize(allScorers.length);
maxScoreSums = new double[allScorers.length];
docAndScoreAccBuffer = new DocAndScoreAccBuffer();
docAndScoreAccBuffer.growNoCopy(INNER_WINDOW_SIZE);

if (this.filter != null && this.filter.twoPhaseView == null && maxDoc >= INNER_WINDOW_SIZE) {
long minScorerCost = allScorers[0].cost;
Expand Down Expand Up @@ -309,6 +307,7 @@ private void collectEssentialScoresIntoWindow(
/** Flush {@link #windowMatches} and {@link #windowScores} into {@link #docAndScoreAccBuffer}. */
private void flushWindowToDocAndScoreAccBuffer(int innerWindowMin, int innerWindowSize)
throws IOException {
docAndScoreAccBuffer.growNoCopy(innerWindowSize);
docAndScoreAccBuffer.size = 0;
windowMatches.forEach(
0,
Expand Down
Loading