Refactor toStringEscaped method for improved efficiency and clarity#16323
Refactor toStringEscaped method for improved efficiency and clarity#16323rajat315315 wants to merge 2 commits into
Conversation
|
Thanks for the PR! A bit thoughts purely on performance. Searching code, the only caller passes wildcardChars = Also if this method is not in critical call path, it would be better to just remove the TODO comment as the current impl is clean and simple. |
|
I agree with @neoremind 's assessment. It looks like an improvement but the extra memory allocation may kill any gains. It'd require some careful benchmarks (not just microbenchmarks but full-stack benchmarks) to see the impact. |
Description