Skip to content

Refactor toStringEscaped method for improved efficiency and clarity #16323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajat315315 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor toStringEscaped method for improved efficiency and clarity #16323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f219db7
Refactor toStringEscaped method for improved efficiency and clarity
rajat315315 Jul 1, 2026
cdbc1ad
Merge branch 'main' into toStringEscaped_opt
dweiss Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions ...rser/src/java/org/apache/lucene/queryparser/flexible/core/util/UnescapedCharSequence.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/
package org.apache.lucene.queryparser.flexible.core.util;

import java.util.BitSet;
import java.util.Locale;

/** CharsSequence with escaped chars information. */
Expand Down Expand Up @@ -89,21 +90,18 @@ public String toStringEscaped() {
* @return a escaped String
*/
public String toStringEscaped(char[] enabledChars) {
// TODO: non efficient implementation, refactor this code
StringBuilder result = new StringBuilder(this.length());
BitSet enabled = new BitSet(1 << 16);
for (char character : enabledChars) {
enabled.set(character);
}

for (int i = 0; i < this.length(); i++) {
if (this.chars[i] == '\\') {
char current = this.chars[i];
if (current == '\\' || (this.wasEscaped[i] && enabled.get(current))) {
result.append('\\');
} else {
for (char character : enabledChars) {
if (this.chars[i] == character && this.wasEscaped[i]) {
result.append('\\');
break;
}
}
}

result.append(this.chars[i]);
result.append(current);
}
return result.toString();
}
Expand Down
Loading