Skip to content

Avoid redundant work in AbstractKnnVectorQuery.rewrite's optimistic path #16324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msokolov merged 2 commits into from
Jul 1, 2026
Merged

Avoid redundant work in AbstractKnnVectorQuery.rewrite's optimistic path #16324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b97a2d
Avoid redundant work in AbstractKnnVectorQuery.rewrite's optimistic path
Jul 1, 2026
b8b0d34
add changes entry
Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ Optimizations

* GITHUB#15597, GITHUB#15777: Reduce memory usage of NeighborArray (Viliam Durina)

* GITHUB#12324: ELiminate redundant work in AbstractKnnVectorQuery.rewrite (Mike Sokolov)

Bug Fixes
---------------------
* GITHUB#14049: Randomize KNN codec params in RandomCodec. Fixes scalar quantization div-by-zero
Expand Down
4 changes: 3 additions & 1 deletion lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,9 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOException {
}
assert leafReaderContexts.size() == tasks.size();
assert perLeafResults.size() == reader.leaves().size();
topK = runSearchTasks(tasks, taskExecutor, perLeafResults, leafReaderContexts);
if (tasks.size() > 0) {
topK = runSearchTasks(tasks, taskExecutor, perLeafResults, leafReaderContexts);
}
}
if (topK.scoreDocs.length == 0) {
return MatchNoDocsQuery.INSTANCE;
Expand Down
Loading