Add bounds validation to ArrayUtil.growExact() and CharTermAttributeImpl.clone()#16345
Closed
vik-hashira wants to merge 3 commits into
Closed
Add bounds validation to ArrayUtil.growExact() and CharTermAttributeImpl.clone()#16345vik-hashira wants to merge 3 commits into
vik-hashira wants to merge 3 commits into
Conversation
Adds bounds checking to all growExact() methods to prevent: - Negative newLength values - newLength less than array.length (maintains backward compatibility with IndexOutOfBoundsException) - newLength exceeding MAX_ARRAY_LENGTH This fixes potential security issues where malicious input could cause excessive memory allocation or undefined behavior.
vik-hashira
force-pushed
the
security-fixes-ArrayUtil-CharTermAttributeImpl
branch
from
fa7979c to
d02e3f5
Compare
Adds bounds checking in clone() method to validate termLength: - Checks termLength is not negative - Checks termLength does not exceed MAX_ARRAY_LENGTH This prevents potential security issues with crafted/malicious TermBuffer values that could cause excessive memory allocation or undefined behavior during cloning.
vik-hashira
force-pushed
the
security-fixes-ArrayUtil-CharTermAttributeImpl
branch
from
d02e3f5 to
3c0d0e6
Compare
Member
|
not vulnerabilities |
- Remove OOM-causing test that allocated MAX_ARRAY_LENGTH - Update CHANGES.txt to reference new bug issue apache#16346 - Rephrase CHANGES.txt entry as bug fix (not security) Co-Authored-By: Claude <noreply@anthropic.com>
vik-hashira
changed the title
Author
|
Thank you for the feedback! I've updated this PR to frame it as a bug fix rather than a security vulnerability:
The validation changes remain the same - they add proper bounds checking with clear error messages for invalid input values. This improves robustness and provides better error messages for edge cases. |
rmuir
reviewed
Jul 2, 2026
| throw new IllegalStateException( | ||
| "termLength (" + this.termLength + ") exceeds maximum allowed array length"); | ||
| } | ||
| t.termBuffer = new char[this.termLength]; |
Member
There was a problem hiding this comment.
this isn't needed. java's bounds checking already does this.
Member
|
i dont agree with the changes, we don't need such additional bounds checks, java already has them. this isn't C. |
Author
|
Thank you for the feedback @rmuir. You're right - Java already provides bounds checking for array operations, and these additional checks are redundant. I appreciate you taking the time to review this. Closing this PR as the changes are not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16346
Summary
This PR adds bounds validation to
ArrayUtil.growExact()methods andCharTermAttributeImpl.clone()to reject invalid input values with clear error messages.Changes
ArrayUtil.growExact()
checkGrowExactLength()for centralized validationnewLength >= 0(throwsIllegalArgumentException)newLength >= array.length(throwsIndexOutOfBoundsExceptionfor backward compatibility)newLength <= MAX_ARRAY_LENGTH(throwsIllegalArgumentException)CharTermAttributeImpl.clone()
termLengthbefore array allocationtermLength >= 0(throwsIllegalStateException)termLength <= ArrayUtil.MAX_ARRAY_LENGTH(throwsIllegalStateException)Backward Compatibility
newLengthvalues will now receive clear error messages instead of undefined behaviorIndexOutOfBoundsExceptionmaintained fornewLength < array.lengthto preserve existing test expectationsTesting
testGrowExactBoundsValidation()to verify validation works correctlytestGrowExacttests continue to pass