Skip to content

Fix integer underflow in assertion in SparseFixedBitSet #16347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romseygeek merged 1 commit into from
Jul 3, 2026
+6 −2
Merged

Fix integer underflow in assertion in SparseFixedBitSet #16347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lucene/core/src/java/org/apache/lucene/util/SparseFixedBitSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ public class SparseFixedBitSet extends BitSet {
private static final long SINGLE_ELEMENT_ARRAY_BYTES_USED = RamUsageEstimator.sizeOf(new long[1]);
private static final int MASK_4096 = (1 << 12) - 1;

private static int blockCount(int length) {
static int blockCount(int length) {
int blockCount = length >>> 12;
if ((blockCount << 12) < length) {
++blockCount;
}
assert (blockCount << 12) >= length;
assert ((long) blockCount << 12) >= length;
return blockCount;
}

Expand Down
4 changes: 4 additions & 0 deletions lucene/core/src/test/org/apache/lucene/util/TestSparseFixedBitSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,8 @@ public void testNextClearBit() {
}
}
}

public void testLargeValuesDoNotOverflow() {
assertEquals(524288, SparseFixedBitSet.blockCount(2147479553));
}
}
Loading