Optimize IndexedDISI by implementing binary search for sparseDocs in …#16349
Open
rajat315315 wants to merge 3 commits into
Open
Optimize IndexedDISI by implementing binary search for sparseDocs in …#16349rajat315315 wants to merge 3 commits into
rajat315315 wants to merge 3 commits into
Conversation
Author
|
I have run the AdvanceBenchmark JMH suite to evaluate the impact of the new binary search implementation on IndexedDISI.The results demonstrate that the inlinedBranchlessBinarySearch approach provides a performance improvement over the existing linearSearch implementation. Throughput Comparison
Existing methods (linearSearch and binarySearch) showed no significant performance degradation on the PR branch compared to main, ensuring that these changes are safe for current workloads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16348
Description
This fix would be particularly useful in the case when we are accessing targetDoc which belong to the same block.
In that case, we won't need to do a linear search over the 4096 Docs in the worst case. It would take only 12 operations
log(N).In the worst case, where the block is
SPARSEand there are 4096 DocIds stored in it and we need to get all docs.. we would be usingadvance()function call which would need to calladvanceWithinBlock()4096 times totalling the number of operations to ~8 million.