Skip to content

SkipBlockRangeIterator should report docCount as its cost #16352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romseygeek merged 2 commits into from
Jul 3, 2026
Merged

SkipBlockRangeIterator should report docCount as its cost #16352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b4779a
SkipBlockRangeIterator should report docCount as its cost
romseygeek Jul 3, 2026
e64ecf6
changes
romseygeek Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,8 @@ Optimizations
* GITHUB#16283: Use Panama Vector API to SIMD-evaluate fixed-cardinality sorted numeric range queries in
rangeIntoBitSet. (Costin Leau)

* GITHUB#16352: Better cost() estimation for SkipBlockRangeIterator. (Alan Woodward)

Bug Fixes
---------------------

Expand Down
2 changes: 1 addition & 1 deletion lucene/core/src/java/org/apache/lucene/search/SkipBlockRangeIterator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public Match getMatch() {

@Override
public long cost() {
return DocIdSetIterator.NO_MORE_DOCS;
return skipper.docCount();
}

/**
Expand Down
6 changes: 6 additions & 0 deletions lucene/core/src/test/org/apache/lucene/search/TestSkipBlockRangeIterator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,10 @@ public void testIntoBitSet() throws Exception {

assertEquals(expected, bitSet);
}

public void testCost() {
DocValuesSkipper skipper = docValuesSkipper(1, 30, random().nextBoolean());
SkipBlockRangeIterator it = new SkipBlockRangeIterator(skipper, 1, 30);
assertEquals(DENSE_END + (MAX_DOC - DENSE_END) / 2, it.cost());
}
}
Loading