Fix seed-dependent failure in TestForceNoBulkScoringQuery#16369
Merged
Conversation
The sanity check added in apache#16350 assumes that searching the un-wrapped ThrowsOnBulkScoreQuery always calls ScorerSupplier#bulkScorer. With newSearcher(reader) the searcher may be an AssertingIndexSearcher, whose ScorerSupplier sometimes builds the bulk scorer from scorer() instead of delegating, so the expected AssertionError is never thrown: gradlew -p lucene/monitor test --tests TestForceNoBulkScoringQuery \ -Dtests.seed=BDD18A3ADD885193 Use a plain IndexSearcher so the dispatch under test is deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestForceNoBulkScoringQuery#testBulkScoringIsDisabledfails deterministically with some seeds since #16350, e.g. on currentmain:The sanity check added in #16350 assumes that searching the un-wrapped
ThrowsOnBulkScoreQueryalways reaches itsScorerSupplier#bulkScorer(). ButnewSearcher(reader)may wrap the searcher withAssertingIndexSearcher, whose scorer supplier deliberately builds the bulk scorer fromscorer()instead of delegating (theusually(random)branch inAssertingWeight— ~1% of seeds in normal runs, more under nightly). In that case the expectedAssertionErroris never thrown and the sanity check fails before the actualForceNoBulkScoringQuerybehavior is exercised.Since the scorer/bulkScorer dispatch is exactly what this test asserts on, use a plain
IndexSearcherso the dispatch is deterministic. The failing seed above passes with this change (and the sanity check still fires, i.e. the plain searcher does reachbulkScorer()).First hit on an unrelated PR's CI (#16368). Happy to restructure — e.g. keep the randomized searcher for the wrapped-query assertion only — if you'd prefer.