Skip to content

Replace deprecated Plexus WriterFactory usage in MavenProjectInput #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anukalp2804 wants to merge 6 commits into
base: master
Choose a base branch
from
+12 −8
Open

Replace deprecated Plexus WriterFactory usage in MavenProjectInput #444

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9637f1
Remove deprecated WriterFactory and MavenXpp3Writer usage
anukalp2804 Jan 25, 2026
60849e9
Remove deprecated WriterFactory and MavenXpp3Writer usage
anukalp2804 Mar 21, 2026
1a02f83
Remove deprecated WriterFactory and MavenXpp3Writer usage
anukalp2804 Mar 22, 2026
6a41be9
fix JDK 17 test failures
anukalp2804 Apr 13, 2026
b783ea5
fix jdk 17 test failures
anukalp2804 Apr 14, 2026
f489889
fix format violations
anukalp2804 Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.IOException;
import java.io.OutputStreamWriter;
import java.io.Writer;
import java.nio.charset.StandardCharsets;
import java.nio.file.DirectoryStream;
Expand Down Expand Up @@ -84,7 +85,6 @@
import org.apache.maven.model.Resource;
import org.apache.maven.model.io.xpp3.MavenXpp3Writer;
import org.apache.maven.project.MavenProject;
import org.codehaus.plexus.util.WriterFactory;
import org.eclipse.aether.RepositorySystem;
import org.eclipse.aether.artifact.DefaultArtifactType;
import org.eclipse.aether.resolution.ArtifactRequest;
Expand Down Expand Up @@ -341,15 +341,19 @@ private boolean checkItemMatchesBaseline(ProjectsInputInfo baselineBuild, Digest
*/
private String getEffectivePom(Model prototype) throws IOException {
ByteArrayOutputStream output = new ByteArrayOutputStream();
try (Writer writer = new OutputStreamWriter(output, StandardCharsets.UTF_8)) {
new MavenXpp3Writer().write(output, prototype);
}

try (Writer writer = WriterFactory.newXmlWriter(output)) {
new MavenXpp3Writer().write(writer, prototype);
// normalize env specifics
final String[] searchList = {baseDirPath.toString(), "\\", "windows", "linux"};
final String[] replacementList = {"", "/", "os.classifier", "os.classifier"};

// normalize env specifics
final String[] searchList = {baseDirPath.toString(), "\\", "windows", "linux"};
final String[] replacementList = {"", "/", "os.classifier", "os.classifier"};
return replaceEachRepeatedly(output.toString(), searchList, replacementList);
}
String result = output.toString(java.nio.charset.StandardCharsets.UTF_8.name());
result = result.replace("\r\n", "\n");
result = result.trim();

return replaceEachRepeatedly(result, searchList, replacementList);
}

private SortedSet<Path> getInputFiles() {
Expand Down