Skip to content

Issue #496 Support maven.build.cache.skipSave as module-level property#497

Open
alascbio wants to merge 1 commit into
apache:masterfrom
alascbio:issue-496-skipsave-module
Open

Issue #496 Support maven.build.cache.skipSave as module-level property#497
alascbio wants to merge 1 commit into
apache:masterfrom
alascbio:issue-496-skipsave-module

Conversation

@alascbio

@alascbio alascbio commented Jun 23, 2026

Copy link
Copy Markdown

Fixes #496

Description

At the moment, the build cache extension supports maven.build.cache.skipCache as a module-level property in pom.xml,
allowing specific modules to skip cache lookup.
However, maven.build.cache.skipSave does not currently behave the same way: it can be set from the CLI, but not as a module-level property.
This creates an inconsistency in multi-module builds.

A concrete issue is that a module can be configured with:

<properties>
    <maven.build.cache.skipCache>true</maven.build.cache.skipCache>
</properties>

to avoid reading from the cache, while still writing new entries to the cache at the end of the build.
In practice, this means a module can be excluded from cache lookup but still update the cache, which is not always desirable.

Expected behavior

Support the following in module pom.xml:

<properties>
    <maven.build.cache.skipSave>true</maven.build.cache.skipSave>
</properties>

When set on a module, this property should prevent cache writes for that module,
while still allowing cache reads unless maven.build.cache.skipCache=true is also set.
This would make skipSave consistent with the existing module-level behavior of skipCache.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).
  • I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support maven.build.cache.skipSave as module-level property

1 participant