Skip to content

Commit ceaecaa

Browse files
Enable ITs for dependecy:remove and use mock dependencies
- new ITs are in subdirectory so should be added to invoker configuration - use mock dependencies to avoid updates by dependabot
1 parent c27eb3d commit ceaecaa

5 files changed

Lines changed: 16 additions & 7 deletions

File tree

pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -484,6 +484,7 @@ under the License.
484484
<pomIncludes>
485485
<pomInclude>*/pom.xml</pomInclude>
486486
<pomInclude>add-dependency/*/pom.xml</pomInclude>
487+
<pomInclude>remove-dependency/*/pom.xml</pomInclude>
487488
<pomInclude>purge-local-repository-without-pom</pomInclude>
488489
</pomIncludes>
489490
<!-- for mrm -->

src/it/projects/remove-dependency/basic/invoker.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18-
invoker.goals = ${project.groupId}:${project.artifactId}:${project.version}:remove -Dgav=org.apache.commons:commons-lang3
18+
invoker.goals = ${project.groupId}:${project.artifactId}:${project.version}:remove -Dgav=org.apache.maven.its.dependency:a1

src/it/projects/remove-dependency/basic/pom.xml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,14 @@
2828
<version>1.0-SNAPSHOT</version>
2929
<dependencies>
3030
<dependency>
31-
<groupId>org.apache.commons</groupId>
32-
<artifactId>commons-lang3</artifactId>
33-
<version>3.18.0</version>
31+
<groupId>org.apache.maven.its.dependency</groupId>
32+
<artifactId>a1</artifactId>
33+
<version>1.0.0</version>
3434
</dependency>
35+
<dependency>
36+
<groupId>org.apache.maven.its.dependency</groupId>
37+
<artifactId>a2</artifactId>
38+
<version>1.0.0</version>
39+
</dependency>
3540
</dependencies>
3641
</project>

src/it/projects/remove-dependency/basic/verify.groovy

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,7 @@ File pom = new File(basedir, "pom.xml")
2121
assert pom.exists()
2222
def xml = new groovy.xml.XmlSlurper().parseText(pom.text)
2323
def deps = xml.dependencies.dependency
24-
def dep = deps.find { it.artifactId.text() == 'commons-lang3' }
25-
assert dep == null : "commons-lang3 should have been removed from dependencies"
24+
assert deps.size() == 1 : "there should be only one dependency left"
25+
26+
def dep = deps.find { it.artifactId.text() == 'a1' }
27+
assert dep.isEmpty() : "a1 should have been removed from dependencies"

src/it/projects/remove-dependency/not-found/verify.groovy

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@
1818
*/
1919

2020
def log = new File(basedir, "build.log")
21-
assert log.text.contains('not found')
21+
assert log.text.contains('Dependency nonexistent:lib not found in <dependencies>') :
22+
"Expected error message about nonexistent dependency should be in build log"

0 commit comments

Comments
 (0)