Skip to content

Exclude dev-tooling dotfiles from RAT check #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascheman merged 1 commit into from
Jun 26, 2026
Merged

Exclude dev-tooling dotfiles from RAT check #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,6 +1282,11 @@ under the License.</licenseText>
<exclude>dependency-reduced-pom.xml</exclude>
<!-- GitHub Support -->
<exclude>.asf.yaml</exclude>
<!-- Developer tooling: version managers / direnv (local, not project source) -->
<exclude>.sdkmanrc</exclude>
<exclude>.tool-versions</exclude>
<exclude>.envrc</exclude>
<exclude>.mise.toml</exclude>
Comment on lines +1285 to +1289

@ascheman ascheman Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. The surrounding excludes in this file (lines 1280-1284: .maven/spy.log, dependency-reduced-pom.xml, .asf.yaml) all use bare filenames, and apache-rat-plugin runs per-module with the inherited <excludes> applied against each module's basedir — so a .sdkmanrc in a submodule would still be matched by the bare pattern at that submodule's rat-check execution.

To stay consistent with the surrounding excludes, leaving as bare. Happy to switch all of them (existing + new) to **/... in a follow-up if maintainers prefer the more defensive form everywhere.

@slawekjaranowski slawekjaranowski Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be simple file name as is

</excludes>
</configuration>
<executions>
Expand Down
Loading